CCM-17116: Adding metrics to eventPublisher in nodejs. To add in othe… #2620
nhsd-angel-pastorcicd-1-pull-request.yaml
on: push
Set CI/CD metadata
6s
Commit stage
/
Scan secrets
16s
Commit stage
/
Check file format
10s
Commit stage
/
Check Markdown format
6s
Commit stage
/
Check English usage
11s
Commit stage
/
Check TODO usage
6s
Commit stage
/
Count lines of code
11s
Commit stage
/
Scan dependencies
49s
Commit stage
/
Run terraform-docs
7s
Commit stage
/
Lint Terraform
19s
Test stage
/
Contract tests
52s
Test stage
/
Linting
1m 8s
Test stage
/
Typecheck
1m 49s
Publish stage
/
Publish packages
Acceptance stage
/
Accessibility test
Acceptance stage
/
Integration test
Acceptance stage
/
Load test
Acceptance stage
/
Security test
Acceptance stage
/
UI performance test
Acceptance stage
/
UI test
Annotations
15 errors and 10 warnings
|
Test stage / Linting:
utils/utils/src/event-publisher/event-publisher.ts#L66
Refactor this function to reduce its Cognitive Complexity from 17 to the 15 allowed
|
|
|
|
|
|
Test stage / Linting:
utils/utils/src/cloudwatch/metric-handler.ts#L55
Expected object keys to be in sorted order. Expected extraDimensions to be before timestamp
|
|
|
|
|
|
Test stage / Linting:
utils/utils/src/__tests__/event-publisher/event-publisher.test.ts#L164
Replace `['uk.nhs.notify.digital.letters.sent.v1_batchFailure',·'Count',·1` with `·[⏎······'uk.nhs.notify.digital.letters.sent.v1_batchFailure',⏎······'Count',⏎······1,⏎····`
|
|
Test stage / Linting:
utils/utils/src/__tests__/event-publisher/event-publisher.test.ts#L163
Replace `['uk.nhs.notify.digital.letters.sent.v1_batchSuccess',·'Count',·1` with `·[⏎······'uk.nhs.notify.digital.letters.sent.v1_batchSuccess',⏎······'Count',⏎······1,⏎····`
|
|
Test stage / Linting:
utils/utils/src/__tests__/event-publisher/event-publisher.test.ts#L81
Replace `'uk.nhs.notify.digital.letters.sent.v1_batchSuccess',·'Count',·2` with `⏎······'uk.nhs.notify.digital.letters.sent.v1_batchSuccess',⏎······'Count',⏎······2,⏎····`
|
|
Test stage / Linting:
utils/utils/src/__tests__/cloudwatch/metric-handler.test.ts#L3
Prefer `globalThis` over `global`
|
|
Test stage / Typecheck
Process completed with exit code 2.
|
|
Test stage / Typecheck
nhs-notify-digital-move-scanned-files-lambda#typecheck: command (/home/runner/work/nhs-notify-digital-letters/nhs-notify-digital-letters/lambdas/move-scanned-files-lambda) /opt/hostedtoolcache/node/24.10.0/x64/bin/npm run typecheck exited (2)
|
|
Test stage / Typecheck
Argument of type '{ eventBusArn: string; dlqUrl: string; logger: winston.Logger; sqsClient: SQSClient; eventBridgeClient: EventBridgeClient; }' is not assignable to parameter of type 'EventPublisherDependencies'.
|
|
Test stage / Unit tests
Process completed with exit code 2.
|
|
Test stage / Unit tests
nhs-notify-digital-letters-file-scanner-lambda#test:unit: command (/home/runner/work/nhs-notify-digital-letters/nhs-notify-digital-letters/lambdas/file-scanner-lambda) /opt/hostedtoolcache/node/24.10.0/x64/bin/npm run test:unit exited (1)
|
|
Test stage / Detect Schema Changes
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: dorny/paths-filter@de90cc6fb38fc0963ad72b210f1f284cd68cea36. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test stage / Contract tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
Test stage / Linting:
utils/utils/src/event-publisher/event-publisher.ts#L121
Function Call Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/event-publisher/event-publisher.ts#L119
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/dynamodb/delete-dynamo-batch.ts#L47
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/dynamodb/delete-dynamo-batch.ts#L34
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/config-reader.ts#L69
Variable Assigned to Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/cache/cache.ts#L52
Generic Object Injection Sink
|
|
Test stage / Linting:
utils/utils/src/cache/cache.ts#L33
Variable Assigned to Object Injection Sink
|
|
Test stage / Unit tests
Node.js 20 actions are deprecated. The following actions are running on Node.js 20 and may not work as expected: actions/cache@0057852bfaa89a56745cba8c7296529d2fc39830. Actions will be forced to run with Node.js 24 by default starting June 2nd, 2026. Node.js 20 will be removed from the runner on September 16th, 2026. Please check if updated versions of these actions are available that support Node.js 24. To opt into Node.js 24 now, set the FORCE_JAVASCRIPT_ACTIONS_TO_NODE24=true environment variable on the runner or in your workflow file. Once Node.js 24 becomes the default, you can temporarily opt out by setting ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION=true. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
lines-of-code-report.json.zip
|
983 Bytes |
sha256:3abaa2b806aee13d6416e5c3f59ffa0018d2824489b592407049d0e1c671607d
|
|
|
pact-contracts
|
609 Bytes |
sha256:fabdd5a19d83381cce0473fe8209497f4afbc620dbf6fa4b991e11b985eafce3
|
|
|
sbom-repository-report.json.zip
|
394 KB |
sha256:3be74c49d21d432d662abd3233a6cb386e1a6263079cf9b042224165f2e05ced
|
|
|
unit-tests
|
1.96 MB |
sha256:e40a8470944a7d3e6eced237580c85081923598bbff49e0eb9b485181e14759c
|
|
|
vulnerabilities-repository-report.json.zip
|
15.4 KB |
sha256:42ad77c4fba8fbd508d891a8ac5d55ef651a5c298af7429712b444d2126bea9b
|
|