APPT-2200 Upgrade to XUnit.v3 (#1621)

Upgrade deprecated Xunit to Xunit.v3 in Unit test projects only.
Attempted to upgrade for Integration test projects (Integration,
CapacityDataExtract, BookingDataExtract) but they all depend on the
XUnit.Gherkin.Quick library, which still uses the XUnit deprecated
version. The projects don't seem to work very well with the XUnit.v3
version (presumably because of dependency issues).

TODO - Upgrade Integration projects to use V3 in the future... somehow!

Author: jsed-nhs

tests/BookingDataExtractTests/BookingDataExtracts.Integration.csproj

@@ -14,7 +14,7 @@
     <PackageReference Include="fluentassertions" Version="7.0.0"/>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
     <PackageReference Include="Moq" Version="4.20.72"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
+    <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.gherkin.quick" Version="4.5.0"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4"/>
   </ItemGroup>

tests/BookingDataExtracts.UnitTests/BookingDataExtracts.UnitTests.csproj

@@ -13,8 +13,8 @@
     <PackageReference Include="coverlet.collector" Version="6.0.4"/>
     <PackageReference Include="FluentAssertions" Version="7.0.0"/>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4"/>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>

tests/CapacityDataExtracts.Integration/CapacityDataExtracts.Integration.csproj

@@ -14,7 +14,7 @@
     <PackageReference Include="fluentassertions" Version="7.0.0"/>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
     <PackageReference Include="Moq" Version="4.20.72"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
+    <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.gherkin.quick" Version="4.5.0"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.1"/>
   </ItemGroup>

tests/CapacityDataExtracts.UnitTests/CapacityDataExtracts.UnitTests.csproj

@@ -12,9 +12,9 @@
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="6.0.4"/>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.1"/>
     <PackageReference Include="FluentAssertions" Version="7.0.0"/>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>

tests/CosmosDbSeederTests/CosmosDbSeederTests.csproj

@@ -12,9 +12,9 @@
   <ItemGroup>
     <PackageReference Include="coverlet.collector" Version="6.0.4"/>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.1"/>
     <PackageReference Include="FluentAssertions" Version="7.0.0"/>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>

tests/Nhs.Appointments.Api.UnitTests/Nhs.Appointments.Api.UnitTests.csproj

@@ -18,7 +18,6 @@
     <PackageReference Include="Microsoft.Extensions.Options" Version="9.0.9" />
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
     <PackageReference Include="Moq" Version="4.20.72" />
-    <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
@@ -27,6 +26,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>

tests/Nhs.Appointments.Audit.UnitTests/Nhs.Appointments.Audit.UnitTests.csproj

@@ -11,7 +11,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.0" />
     <PackageReference Include="Moq" Version="4.20.72" />
-    <PackageReference Include="xunit" Version="2.9.3" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
@@ -20,6 +19,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>

tests/Nhs.Appointments.Core.UnitTests/Nhs.Appointments.Core.UnitTests.csproj

@@ -15,7 +15,7 @@
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1" />
     <PackageReference Include="Moq" Version="4.20.72" />
     <PackageReference Include="Okta.Sdk" Version="9.2.3" />
-    <PackageReference Include="xunit" Version="2.9.3" />
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>

tests/Nhs.Appointments.Jobs.Aggregator.UnitTests/Nhs.Appointments.Jobs.Aggregator.UnitTests.csproj

@@ -13,8 +13,8 @@
         <PackageReference Include="coverlet.collector" Version="6.0.0"/>
         <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0"/>
         <PackageReference Include="Moq" Version="4.20.72" />
-        <PackageReference Include="xunit" Version="2.5.3"/>
         <PackageReference Include="xunit.runner.visualstudio" Version="2.5.3"/>
+        <PackageReference Include="xunit.v3" Version="3.2.2" />
     </ItemGroup>
 
     <ItemGroup>

tests/Nhs.Appointments.Jobs.BlobAuditor.UnitTests/Nhs.Appointments.Jobs.BlobAuditor.UnitTests.csproj

@@ -12,7 +12,6 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.14.1"/>
     <PackageReference Include="Moq" Version="4.20.72"/>
-    <PackageReference Include="xunit" Version="2.9.3"/>
     <PackageReference Include="xunit.runner.visualstudio" Version="3.1.4">
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
@@ -21,6 +20,7 @@
       <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
       <PrivateAssets>all</PrivateAssets>
     </PackageReference>
+    <PackageReference Include="xunit.v3" Version="3.2.2" />
   </ItemGroup>
 
   <ItemGroup>