APPT-2150 - Removing auto mapper as a dependency (#1620)

# Description

Removing Auto Mapper as a dependency on the solution and updating all
mappings in the persistence layer. There should be no functional changes
so also ensuring all existing integration tests and playwright tests
pass.

Fixes # (issue)

# Checklist:

- [ ] My work is behind a feature toggle (if appropriate)
- [ ] If my work is behind a feature toggle, I've added a full suite of
tests for both the ON and OFF state
- [ ] The ticket number is in the Pull Request title, with format
"APPT-XXX: My Title Here"
- [x] I have ran npm tsc / lint (in the future these will be ran
automatically)
- [x] My code generates no new .NET warnings (in the future these will
be treated as errors)
- [ ] If I've added a new Function, it is disabled in all but one of the
terraform groups (e.g. http_functions)
- [ ] If I've added a new Function, it has both unit and integration
tests. Any request body validators have unit tests also
- [ ] If I've made UI changes, I've added appropriate Playwright and
Jest tests
- [ ] If I've added/updated an end-point, I've added the appropriate
annotations and tested the Swagger documentation reflects the change

Author: ste-banks

src/api/Nhs.Appointments.Api/FunctionConfigurationExtensions.cs

@@ -117,7 +117,6 @@ public static IFunctionsWorkerApplicationBuilder ConfigureFunctionDependencies(
             .AddTransient<IClinicalServiceProvider, ClinicalServiceProvider>()
             .AddScoped<IMetricsRecorder, InMemoryMetricsRecorder>()
             .AddUserNotifications(configuration)
-            .AddAutoMapper(typeof(CosmosAutoMapperProfile))
             .AddTransient<IAdminUserDataImportHandler, AdminUserDataImportHandler>()
             .AddTransient<ISiteStatusDataImportHandler, SiteStatusDataImportHandler>()
             .AddTransient<IAvailableSlotsFilter, AvailableSlotsFilter>()

src/api/Nhs.Appointments.Core/Bookings/BookingAvailabilityStateService.cs

@@ -156,10 +156,12 @@ private BookingAvailabilityState BuildState(IEnumerable<Booking> bookings, List<
 
         var state = new BookingAvailabilityState();
 
+        var bookingsList = bookings.ToList();
+
         //have to materialise to a list as we transform the data within
         var slotsList = sessions.SelectMany(session => session.ToSlots()).ToList();
 
-        var liveBookings = bookings.Where(x => _liveStatuses.Contains(x.Status));
+        var liveBookings = bookingsList.Where(x => _liveStatuses.Contains(x.Status));
 
         List<DayAvailabilitySummary> daySummaries = [];
 
@@ -249,7 +251,7 @@ private BookingAvailabilityState BuildState(IEnumerable<Booking> bookings, List<
                 state.AvailableSlots = slotsList.Where(s => s.Capacity > 0);
                 break;
             case BookingAvailabilityStateReturnType.Summary:
-                state.Summary = GenerateSummary(bookings, daySummaries);
+                state.Summary = GenerateSummary(bookingsList, daySummaries);
                 break;
             case BookingAvailabilityStateReturnType.Recalculations:
             case BookingAvailabilityStateReturnType.SessionUpdateProposalMetrics:

src/api/Nhs.Appointments.Persistance/AccessibilityDefinitionsStore.cs

@@ -8,7 +8,7 @@ public class AccessibilityDefinitionsStore(ITypedDocumentCosmosStore<Accessibili
     private const string AccessibilitySetsDocumentId = "accessibilities";
     public async Task<IEnumerable<AccessibilityDefinition>> GetAccessibilityDefinitionsDocument()
     {
-        var document = await cosmosStore.GetDocument<AccessibilityDefinitionsDocument>(AccessibilitySetsDocumentId);
+        var document = await cosmosStore.GetDocument(AccessibilitySetsDocumentId);
         return document.AccessibilityDefinitions;
     }
 }

src/api/Nhs.Appointments.Persistance/AggregationStore.cs

@@ -11,12 +11,13 @@ public class AggregationStore(ITypedDocumentCosmosStore<AggregationDocument> sto
 
     public async Task<Aggregation> GetLastRun()
     {
-        return await Store.GetByIdOrDefaultAsync<Aggregation>(AggregationDocumentId);
+        var document = await Store.GetByIdOrDefaultAsync(AggregationDocumentId);
+        return document is null ? null : MapToAggregation(document);
     }
 
     public async Task SetLastRun(DateTimeOffset lastTriggerUtcDate, DateOnly aggregationFrom, DateOnly aggregationTo, DateOnly dateUntilAggregated)
     {
-        var document = await Store.GetByIdOrDefaultAsync<AggregationDocument>(AggregationDocumentId);
+        var document = await Store.GetByIdOrDefaultAsync(AggregationDocumentId);
 
         if (document is not null)
         {
@@ -41,4 +42,15 @@ await Store.WriteAsync(new AggregationDocument
             }
         });
     }
+
+    private static Aggregation MapToAggregation(AggregationDocument document)
+    {
+        return new Aggregation
+        {
+            LastTriggeredUtcDate = document.LastTriggeredUtcDate,
+            FromDateOnly = document.LastRunMetaData.FromDateOnly,
+            ToDateOnly = document.LastRunMetaData.ToDateOnly,
+            LastRanToDateOnly = document.LastRunMetaData.LastRanToDateOnly
+        };
+    }
 }

src/api/Nhs.Appointments.Persistance/AvailabilityCreatedEventDocumentStore.cs

@@ -50,8 +50,19 @@ public async Task<IEnumerable<AvailabilityCreatedEvent>> GetAvailabilityCreatedE
     {
         var docType = documentStore.GetDocumentType();
 
-        return await documentStore.RunQueryAsync<AvailabilityCreatedEvent>(b =>
+        var documents = await documentStore.RunQueryAsync(b =>
             b.DocumentType == docType
             && b.Site == site);
+
+        return documents.Any() ? documents.Select(d => new AvailabilityCreatedEvent()
+        {
+            Created = d.Created,
+            By = d.By,
+            Site = d.Site,
+            Template = d.Template,
+            From = d.From,
+            To = d.To,
+            Sessions = d.Sessions
+        }) : [];
     }
-}
+}

src/api/Nhs.Appointments.Persistance/AvailabilityDocumentStore.cs

@@ -12,7 +12,7 @@ public async Task<IEnumerable<SessionInstance>> GetSessions(string site, DateOnl
     {
         var results = new List<SessionInstance>();
         var docType = documentStore.GetDocumentType();
-        var documents = await documentStore.RunQueryAsync<DailyAvailabilityDocument>(b =>
+        var documents = await documentStore.RunQueryAsync(b =>
             b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= to);
 
         foreach (var day in documents)
@@ -65,8 +65,9 @@ public async Task ApplyAvailabilityTemplate(string site, DateOnly date, Session[
     public async Task<IEnumerable<DailyAvailability>> GetDailyAvailability(string site, DateOnly from, DateOnly to)
     {
         var docType = documentStore.GetDocumentType();
-        return await documentStore.RunQueryAsync<DailyAvailability>(b =>
+        var availabilityDocuments = await documentStore.RunQueryAsync(b =>
             b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= to);
+        return availabilityDocuments.Select(MapToDailyAvailability) ?? [];
     }
 
     public async Task<SessionInstance> CancelSession(string site, DateOnly date, Session session)
@@ -89,9 +90,7 @@ public async Task<SessionInstance> CancelSession(string site, DateOnly date, Ses
         return new SessionInstance(dayDocument.Date.ToDateTime(session.From),
             dayDocument.Date.ToDateTime(session.Until))
         {
-            Services = session.Services,
-            SlotLength = session.SlotLength,
-            Capacity = session.Capacity,
+            Services = session.Services, SlotLength = session.SlotLength, Capacity = session.Capacity,
         };
     }
 
@@ -118,7 +117,6 @@ SELECT VALUE svc FROM session IN bd.sessions JOIN svc IN session.services
             .WithParameter("@requestedServiceCount", services.Count);
 
         var dailyAvailabilityCount = (await documentStore.RunSqlQueryAsync<int>(queryDef)).Single();
-
         return dailyAvailabilityCount > 0;
     }
 
@@ -134,7 +132,7 @@ public async Task CancelDayAsync(string site, DateOnly date)
     public async Task<OperationResult> EditSessionsAsync(string site, DateOnly from, DateOnly until, Session sessionMatcher, Session sessionReplacement)
     {
         var docType = documentStore.GetDocumentType();
-        var documents = await documentStore.RunQueryAsync<DailyAvailabilityDocument>(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
+        var documents = await documentStore.RunQueryAsync(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
 
         if (documents == null || !documents.Any())
         {
@@ -152,7 +150,7 @@ public async Task<OperationResult> EditSessionsAsync(string site, DateOnly from,
     public async Task<OperationResult> CancelMultipleSessions(string site, DateOnly from, DateOnly until, Session sessionMatcher = null)
     {
         var docType = documentStore.GetDocumentType();
-        var documents = await documentStore.RunQueryAsync<DailyAvailabilityDocument>(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
+        var documents = await documentStore.RunQueryAsync(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
 
         if (documents == null || !documents.Any())
         {
@@ -175,7 +173,7 @@ public async Task<OperationResult> CancelMultipleSessions(string site, DateOnly
     public async Task<int> CancelAllSessionsInDateRange(string site, DateOnly from, DateOnly until)
     {
         var docType = documentStore.GetDocumentType();
-        var documents = await documentStore.RunQueryAsync<DailyAvailabilityDocument>(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
+        var documents = await documentStore.RunQueryAsync(b => b.DocumentType == docType && b.Site == site && b.Date >= from && b.Date <= until);
 
         if (documents is null || !documents.Any())
         {
@@ -231,7 +229,7 @@ private async Task PatchAvailabilityDocument(string documentId, Session[] sessio
 
     private async Task<DailyAvailabilityDocument> GetOrDefaultAsync(string documentId, string partitionKey)
     {
-        return await documentStore.GetByIdOrDefaultAsync<DailyAvailabilityDocument>(documentId, partitionKey);
+        return await documentStore.GetByIdOrDefaultAsync(documentId, partitionKey);
     }
 
     private static Session FindMatchingSession(List<Session> sessions, Session sessionToMatch)
@@ -272,4 +270,20 @@ private static bool SessionsMatch(Session session, Session sessionToMatch)
             && session.Capacity == sessionToMatch.Capacity
             && session.Services.SequenceEqual(sessionToMatch.Services);
     }
+
+    private static DailyAvailability MapToDailyAvailability(DailyAvailabilityDocument document)
+    {
+        return document is null ? null : new DailyAvailability
+        {
+            Date = document.Date,
+            Sessions = [.. document.Sessions.Select(s => new Session
+            {
+                From = s.From,
+                Until = s.Until,
+                Services = s.Services,
+                SlotLength = s.SlotLength,
+                Capacity = s.Capacity
+            })]
+        };
+    }
 }