[PRMP-1718] Fix incorrect domain for api gateway and feedback (#276)

Author: NogaNHS

infrastructure/lambda-feature-flags.tf

@@ -8,7 +8,7 @@ module "feature-flags-gateway" {
   gateway_path        = "FeatureFlags"
   authorizer_id       = aws_api_gateway_authorizer.repo_authoriser.id
   require_credentials = true
-  origin              = "'https://${terraform.workspace}.${var.domain}'"
+  origin              = contains(["prod"], terraform.workspace) ? "'https://${var.domain}'" : "'https://${terraform.workspace}.${var.domain}'"
 
   # Lambda Variables
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn

infrastructure/lambda-send-feedback.tf

@@ -1,6 +1,5 @@
 locals {
   ses_feedback_sender_email_address = (
-    local.is_production ? "feedback@${var.certificate_domain}" :
     local.is_sandbox ? "feedback@ndr-dev.${var.domain}" :
     "feedback@${terraform.workspace}.${var.domain}"
   )
@@ -20,7 +19,7 @@ module "send-feedback-gateway" {
   gateway_path        = "Feedback"
   authorizer_id       = aws_api_gateway_authorizer.repo_authoriser.id
   require_credentials = true
-  origin              = "'https://${terraform.workspace}.${var.domain}'"
+  origin              = contains(["prod"], terraform.workspace) ? "'https://${var.domain}'" : "'https://${terraform.workspace}.${var.domain}'"
 
   # Lambda Variables
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn

infrastructure/lambda-upload-confirm-result.tf

@@ -8,7 +8,7 @@ module "upload_confirm_result_gateway" {
   gateway_path        = "UploadConfirm"
   authorizer_id       = aws_api_gateway_authorizer.repo_authoriser.id
   require_credentials = true
-  origin              = "'https://${terraform.workspace}.${var.domain}'"
+  origin              = contains(["prod"], terraform.workspace) ? "'https://${var.domain}'" : "'https://${terraform.workspace}.${var.domain}'"
 
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn
   owner             = var.owner

infrastructure/lambda-virus-scan-result.tf

@@ -8,7 +8,7 @@ module "virus_scan_result_gateway" {
   gateway_path        = "VirusScan"
   authorizer_id       = aws_api_gateway_authorizer.repo_authoriser.id
   require_credentials = true
-  origin              = "'https://${terraform.workspace}.${var.domain}'"
+  origin              = contains(["prod"], terraform.workspace) ? "'https://${var.domain}'" : "'https://${terraform.workspace}.${var.domain}'"
 
   # Lambda Variables
   api_execution_arn = aws_api_gateway_rest_api.ndr_doc_store_api.execution_arn

infrastructure/ses.tf

@@ -1,11 +1,6 @@
 locals {
-  domain_prefix = (
-    local.is_production ? var.environment :
-    local.is_sandbox ? "ndr-dev" :
-    terraform.workspace
-  )
-
-  domain = "${local.domain_prefix}.${var.domain}"
+  domain_prefix = terraform.workspace
+  domain        = "${local.domain_prefix}.${var.domain}"
 }
 
 module "ndr-feedback-mailbox" {