[PRM-917] Remove default_lambda_layers variable and update lifecycle ignore_changes for layers

Signed-off-by: NogaNHS <127490765+NogaNHS@users.noreply.github.com>

Author: NogaNHS

infrastructure/lambda-data-collection.tf

@@ -78,7 +78,6 @@ module "data-collection-lambda" {
   }
   is_gateway_integration_needed = false
   is_invoked_from_gateway       = false
-  default_lambda_layers         = []
 
   depends_on = [
     module.ndr-app-config,

infrastructure/modules/lambda/locals.tf

@@ -25,12 +25,12 @@ resource "aws_lambda_function" "lambda" {
     security_group_ids = var.vpc_security_group_ids
   }
 
-  layers = local.lambda_layers
 
   lifecycle {
     ignore_changes = [
       # These are required as Lambdas are deployed via the CI/CD pipelines
       source_code_hash,
+      layers
     ]
   }
 

infrastructure/modules/lambda/main.tf

@@ -100,17 +100,6 @@ variable "persistent_workspaces" {
   default     = ["ndr-dev", "ndr-test", "pre-prod", "prod"]
 }
 
-variable "default_lambda_layers" {
-  type = list(string)
-  default = [
-    "arn:aws:lambda:eu-west-2:282860088358:layer:AWS-AppConfig-Extension:238"
-  ]
-}
-
-variable "extra_lambda_layers" {
-  type    = list(string)
-  default = ["arn:aws:lambda:eu-west-2:580247275435:layer:LambdaInsightsExtension:64"]
-}
 
 variable "kms_deletion_window" {
   description = "Lambda KMS time to deletion in days"