Convert remaining jobs to Sidekiq

This converts the remaining ActiveJob jobs to be Sidekiq-only. These
jobs all accept arguments, meaning we need to be careful about the
serialisation and deserialisation of the arguments.

To ensure the migration doesn't result in any missed jobs, this commit
adds Sidekiq-only versions of all the jobs which are queued instead of
the ActiveJob ones. Any ActiveJob jobs left in the queue will continue
to execute.

Jira-Issue: MAV-7288

Author: thomasleese

app/controllers/class_imports_controller.rb

@@ -29,7 +29,7 @@ def create
                 )
 
     if @class_import.save
-      ProcessImportJob.perform_later(@class_import)
+      ProcessImportSidekiqJob.perform_async(@class_import.to_global_id.to_s)
       redirect_to imports_path, flash: { success: "Import processing started" }
     else
       render :new, status: :unprocessable_content and return

app/controllers/cohort_imports_controller.rb

@@ -27,7 +27,7 @@ def create
                 )
 
     if @cohort_import.save
-      ProcessImportJob.perform_later(@cohort_import)
+      ProcessImportSidekiqJob.perform_async(@cohort_import.to_global_id.to_s)
       redirect_to imports_path, flash: { success: "Import processing started" }
     else
       render :new, status: :unprocessable_content and return

app/controllers/consent_forms_controller.rb

@@ -118,9 +118,9 @@ def create_patient
     end
 
     if patient.nhs_number.nil?
-      PatientNHSNumberLookupJob.perform_later(patient)
+      PatientNHSNumberLookupSidekiqJob.perform_async(patient.id)
     else
-      PatientUpdateFromPDSJob.perform_later(patient)
+      PatientUpdateFromPDSSidekiqJob.perform_async(patient.id, nil)
     end
 
     flash[:success] = "#{patient.full_name}’s record created from a consent \

app/controllers/immunisation_imports_controller.rb

@@ -23,7 +23,9 @@ def create
                 )
 
     if @immunisation_import.save
-      ProcessImportJob.perform_later(@immunisation_import)
+      ProcessImportSidekiqJob.perform_async(
+        @immunisation_import.to_global_id.to_s
+      )
       redirect_to imports_path, flash: { success: "Import processing started" }
     else
       render :new, status: :unprocessable_content and return

app/controllers/parent_interface/consent_forms/edit_controller.rb

@@ -96,7 +96,7 @@ def handle_ethnicity_completion!(model)
       # parent decides to answer "Yes" or "No" (they might not)
       # to the ethnicity questions, the job will make sure the
       # ethnicity information is copied to the matched patient.
-      ProcessConsentFormJob.perform_later(model.id)
+      ProcessConsentFormSidekiqJob.perform_async(model.id)
 
       redirect_to submitted_parent_interface_consent_form_path(model)
     end

app/controllers/parent_interface/consent_forms_controller.rb

@@ -67,7 +67,7 @@ def record
       # answering. Running the job ensures the consent form is still
       # processed and, if ethnicity was provided, it gets copied
       # onto the matched patient.
-      ProcessConsentFormJob.perform_later(@consent_form.id)
+      ProcessConsentFormSidekiqJob.perform_async(@consent_form.id)
 
       if Flipper.enabled?(:ethnicity_capture)
         redirect_to parent_interface_consent_form_edit_path(

app/controllers/patients/edit_controller.rb

@@ -22,7 +22,9 @@ def update_nhs_number
     @patient.invalidated_at = nil
 
     if @patient.save
-      PatientUpdateFromPDSJob.perform_later(@patient)
+      if @patient.nhs_number.present?
+        PatientUpdateFromPDSSidekiqJob.perform_async(@patient.id, nil)
+      end
 
       redirect_to edit_patient_path(@patient)
     else

app/controllers/sessions/manage_consent_reminders_controller.rb

@@ -7,7 +7,10 @@ def show
   end
 
   def create
-    SendManualSchoolConsentRemindersJob.perform_now(@session, current_user:)
+    SendManualSchoolConsentRemindersJob.perform_async(
+      @session.id,
+      current_user.id
+    )
 
     redirect_to session_path(@session),
                 flash: {

app/forms/bulk_remove_parents_form.rb

@@ -31,7 +31,7 @@ def save!
     import
       .parent_relationship_ids
       .each_slice(BATCH_SIZE) do |batch_ids|
-        BulkRemoveParentRelationshipsJob.perform_later(
+        BulkRemoveParentRelationshipsSidekiqJob.perform_async(
           import.to_global_id.to_s,
           batch_ids,
           current_user.id,

app/jobs/bulk_remove_parent_relationships_sidekiq_job.rb

@@ -0,0 +1,19 @@
+# frozen_string_literal: true
+
+class BulkRemoveParentRelationshipsSidekiqJob < ApplicationJobSidekiq
+  sidekiq_options queue: :imports
+
+  def perform(
+    import_global_id,
+    parent_relationship_ids_batch,
+    user_id,
+    remove_option
+  )
+    BulkRemoveParentRelationshipsJob.new.perform(
+      import_global_id,
+      parent_relationship_ids_batch,
+      user_id,
+      remove_option
+    )
+  end
+end