Create notices when patient moves teams

When a patient is mvoed between teams we need to ensure important notices are created for the new team to see too.

MAV-2309

Author: murugapl

app/models/concerns/contributes_to_patient_teams.rb

@@ -222,11 +222,19 @@ def insert_patient_teams_relationships
     end
 
     def sync_patient_teams_table_on_patient_ids(pk_ids)
+      affected_patient_ids = []
       transaction do
         contributing_subqueries.each do |key, subquery|
           patient_id_source =
             connection.quote_string(subquery[:patient_id_source])
           sterile_key = connection.quote(PatientTeam.sources.fetch(key.to_s))
+
+          affected_patient_ids |=
+            select("#{subquery[:patient_id_source]} as patient_id")
+              .where("#{table_name}.id = ANY(ARRAY[?]::bigint[])", pk_ids)
+              .distinct
+              .pluck(:patient_id)
+
           patient_relationships_to_remove =
             select("#{patient_id_source} as patient_id")
               .where("#{table_name}.id = ANY(ARRAY[?]::bigint[])", pk_ids)
@@ -247,6 +255,10 @@ def sync_patient_teams_table_on_patient_ids(pk_ids)
 
         PatientTeam.missing_sources.delete_all
       end
+
+      if affected_patient_ids.any?
+        ImportantNoticeGeneratorJob.perform_later(affected_patient_ids)
+      end
     end
 
     def add_patient_team_relationships

app/models/patient_team.rb

@@ -39,6 +39,8 @@ class PatientTeam < ApplicationRecord
                school_move_school: 5
              }
 
+  after_create_commit :generate_important_notices
+
   def add_source!(source)
     update!(sources: Array(sources) | [source.to_s])
   end
@@ -47,4 +49,10 @@ def remove_source!(source)
     self.sources = sources.reject { it == source.to_s }
     sources.empty? ? delete : save!
   end
+
+  private
+
+  def generate_important_notices
+    ImportantNoticeGeneratorJob.perform_later([patient_id])
+  end
 end

spec/factories/vaccination_records.rb

@@ -121,6 +121,10 @@
 
     notify_parents { true }
 
+    after(:create) do |vaccination_record|
+      ImportantNoticeGeneratorJob.perform_now([vaccination_record.patient_id])
+    end
+
     trait :sourced_from_nhs_immunisations_api do
       source { "nhs_immunisations_api" }
       nhs_immunisations_api_id { SecureRandom.uuid }

spec/features/manage_children_spec.rb

@@ -174,6 +174,17 @@
     then_i_see_the_notice_of_sensitive
   end
 
+  scenario "Important notices for patient added to new team" do
+    given_another_team_exists
+    and_a_patient_with_all_notices_exists
+
+    when_the_patient_is_added_to_the_new_team
+    when_i_go_to_the_imports_page_as_a_superuser_in_the_new_team
+    and_i_click_on_notices
+    then_i_see_all_patient_notices
+    and_i_do_not_see_gillick_no_notify_notices
+  end
+
   def given_my_team_exists
     @hpv = Programme.hpv
     @flu = Programme.flu
@@ -188,6 +199,18 @@ def given_my_team_exists
     TeamSessionsFactory.call(@team, academic_year: AcademicYear.current)
   end
 
+  def given_another_team_exists
+    @new_team =
+      create(
+        :team,
+        :with_generic_clinic,
+        :with_one_nurse,
+        programmes: [@hpv, @flu]
+      )
+
+    TeamSessionsFactory.call(@new_team, academic_year: AcademicYear.current)
+  end
+
   def given_patients_exist
     school = create(:school, team: @team)
 
@@ -288,6 +311,20 @@ def when_a_restricted_patient_exists
     @restricted_patient = create(:patient, :restricted, session:)
   end
 
+  def and_a_patient_with_all_notices_exists
+    session = create(:session, team: @team, programmes: [@hpv])
+    @patient_all_notices =
+      create(:patient, :deceased, :invalidated, :restricted, session:)
+    create(
+      :vaccination_record,
+      notify_parents: false,
+      patient: @patient_all_notices,
+      programme: @hpv,
+      session:
+    )
+    expect(@patient_all_notices.important_notices.count).to eq(4)
+  end
+
   def when_i_click_on_children
     sign_in @team.users.first
 
@@ -462,6 +499,12 @@ def when_i_go_to_the_imports_page_as_a_superuser
     visit "/imports"
   end
 
+  def when_i_go_to_the_imports_page_as_a_superuser_in_the_new_team
+    sign_in @new_team.users.first, superuser: true
+
+    visit "/imports"
+  end
+
   def when_i_wait_for_the_sync_to_complete
     Sidekiq::Job.drain_all
   end
@@ -484,6 +527,21 @@ def when_i_click_on_notices
 
   alias_method :and_i_click_on_notices, :when_i_click_on_notices
 
+  def when_the_patient_is_added_to_the_new_team
+    SchoolMove.new(
+      academic_year: AcademicYear.current,
+      home_educated: false,
+      patient: @patient_all_notices,
+      team: @new_team
+    ).confirm!
+
+    expect(@patient_all_notices.teams).to include(@new_team)
+    expect(@patient_all_notices.teams).to include(@team)
+
+    perform_enqueued_jobs_while_exists(only: SyncPatientTeamJob)
+    perform_enqueued_jobs_while_exists(only: ImportantNoticeGeneratorJob)
+  end
+
   def then_i_see_no_notices
     expect(page).to have_content("There are currently no important notices.")
   end
@@ -506,6 +564,22 @@ def then_i_see_the_notice_of_sensitive
     expect(page).to have_content("Record flagged as sensitive")
   end
 
+  def then_i_see_all_patient_notices
+    expect(page).to have_content("Important notices (3)")
+    expect(page).to have_content(@patient_all_notices.full_name).exactly(
+      3
+    ).times
+    expect(page).to have_content("Record updated with child’s date of death")
+    expect(page).to have_content("Record flagged as invalid")
+    expect(page).to have_content("Record flagged as sensitive")
+  end
+
+  def and_i_do_not_see_gillick_no_notify_notices
+    expect(page).not_to have_content(
+      "does not want their parents to be notified"
+    )
+  end
+
   def then_the_vaccination_record_is_created_with_the_nhs
     expect(@stubbed_post_request).to have_been_requested
   end