Don't ask follow up root questions in verbal consent

When recording health answers in verbal consent we don't want to ask for
any questions that don't require notes as these have no effect on triage
and instead we ask follow up questions which are the real questions.

This is needed to support the asthma question for the flu programme
where we ask about asthma, and then have some follow up questions. The
asthma question alone has no impact on the triage result.

Jira-Issue: MAV-1391

Author: thomasleese

app/controllers/draft_consents_controller.rb

@@ -87,9 +87,13 @@ def handle_confirm
   end
 
   def handle_questions
-    questions_attrs = update_params.except(:wizard_step).values
-    @draft_consent.health_answers.each_with_index do |ha, index|
-      ha.assign_attributes(questions_attrs[index])
+    questions_attrs = update_params.except(:wizard_step)
+
+    @draft_consent.health_answers.each_with_index do |health_answer, index|
+      attributes = questions_attrs["question_#{index}"]
+      if health_answer.requires_notes?
+        health_answer.assign_attributes(attributes)
+      end
     end
 
     @draft_consent.assign_attributes(wizard_step: current_step)

app/models/draft_consent.rb

@@ -427,6 +427,8 @@ def health_answers_are_valid
     return if health_answers.map(&:valid?).all?
 
     health_answers.each_with_index do |health_answer, index|
+      next unless health_answer.requires_notes?
+
       health_answer.errors.messages.each do |field, messages|
         messages.each do |message|
           errors.add("question-#{index}-#{field}", message)

app/views/draft_consents/questions.html.erb

@@ -15,18 +15,19 @@
   <% content_for(:before_content) { f.govuk_error_summary } %>
 
   <% @draft_consent.health_answers.each_with_index do |health_answer, index| %>
-    <%= f.fields_for "question_#{index}", health_answer do |ff| %>
-      <%= ff.govuk_radio_buttons_fieldset :question,
-                                          legend: { size: "s", text: health_answer.question },
-                                          hint: { text: health_answer.hint } do %>
-        <%= ff.govuk_radio_button :response, "yes",
-                                  label: { text: "Yes" },
-                                  link_errors: true do %>
-          <%= ff.govuk_text_area :notes,
-                                 label: { text: "Give details" } %>
+    <% if health_answer.requires_notes? %>
+      <%= f.fields_for "question_#{index}", health_answer do |ff| %>
+        <%= ff.govuk_radio_buttons_fieldset :question,
+                                            legend: { size: "s", text: health_answer.question },
+                                            hint: { text: health_answer.hint } do %>
+          <%= ff.govuk_radio_button :response, "yes",
+                                    label: { text: "Yes" },
+                                    link_errors: true do %>
+            <%= ff.govuk_text_area :notes, label: { text: "Give details" } %>
+          <% end %>
+
+          <%= ff.govuk_radio_button :response, "no", label: { text: "No" } %>
         <% end %>
-        <%= ff.govuk_radio_button :response, "no",
-                                  label: { text: "No" } %>
       <% end %>
     <% end %>
   <% end %>

spec/features/verbal_consent_given_spec.rb

@@ -59,15 +59,15 @@ def when_i_record_that_verbal_consent_was_given
   def when_i_record_that_verbal_nasal_consent_was_given
     record_that_verbal_consent_was_given(
       consent_option: "Yes, for the nasal spray",
-      number_of_health_questions: 10,
+      number_of_health_questions: 9,
       triage_option: "Yes, it’s safe to vaccinate with nasal spray"
     )
   end
 
   def when_i_record_that_verbal_nasal_and_injection_consent_was_given
     record_that_verbal_consent_was_given(
       consent_option: "Yes, for the nasal spray",
-      number_of_health_questions: 11,
+      number_of_health_questions: 10,
       triage_option: "Yes, it’s safe to vaccinate with nasal spray",
       injective_alternative: true
     )