Skip to content

Commit f545e66

Browse files
Use separate stylesheets for public- and SAIS-facing interfaces
1 parent 7f4c70c commit f545e66

9 files changed

Lines changed: 31 additions & 42 deletions

File tree

Lines changed: 14 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,20 @@
1-
@use "sass:color";
2-
31
// NHS.UK frontend components
4-
@forward "vendor/nhsuk-frontend";
2+
@forward "vendor/nhsuk-frontend" with (
3+
$nhsuk-page-width: 1100px,
4+
$nhsuk-grid-widths: (
5+
one-quarter: 25%,
6+
one-third: 33.3333%,
7+
one-half: 50%,
8+
two-thirds: 66.6666%,
9+
three-quarters: 75%,
10+
full: 100%,
11+
filters: 30%,
12+
results: 70%,
13+
)
14+
);
515

616
// GOV.UK Frontend components
717
@forward "vendor/govuk-frontend";
818

9-
// App-specific components
19+
// Application components
1020
@forward "components";

app/assets/stylesheets/components/_index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@
1212
@forward "highlight";
1313
@forward "search-input";
1414
@forward "secondary-navigation";
15-
@forward "signed-in";
1615
@forward "status";
1716
@forward "summary-list";
1817
@forward "tables";

app/assets/stylesheets/components/_signed-in.scss

Lines changed: 0 additions & 20 deletions
This file was deleted.

app/assets/stylesheets/core/settings/_index.scss

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
@use "sass:color";
22
@use "../../vendor/nhsuk-frontend" as *;
33

4-
$page-width: 1100px;
54
// stylelint-disable-next-line scss/dollar-variable-pattern
65
$color_dark-orange: color.scale(
76
color.mix($color_nhsuk-red, $color_nhsuk-yellow, 60%),

app/assets/stylesheets/public.scss

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
// NHS.UK frontend components
2+
@forward "vendor/nhsuk-frontend";
3+
4+
// Public-facing GOV.UK Frontend components
5+
@forward "vendor/govuk-frontend/public";
6+
7+
// Public-facing components
8+
@forward "components/autocomplete";
9+
@forward "components/environment";
10+
@forward "components/summary-list";
Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
@use "base" as *;
2+
3+
@forward "components/notification-banner";
Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1,13 +1 @@
1-
@forward "pkg:nhsuk-frontend/packages/core" with (
2-
$nhsuk-fonts-path: "/",
3-
$nhsuk-grid-widths: (
4-
one-quarter: 25%,
5-
one-third: 33.3333%,
6-
one-half: 50%,
7-
two-thirds: 66.6666%,
8-
three-quarters: 75%,
9-
full: 100%,
10-
filters: 30%,
11-
results: 70%,
12-
)
13-
);
1+
@forward "pkg:nhsuk-frontend/packages/core";

app/views/layouts/application.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
<title><%= page_title(@service_name) %></title>
88

9-
<%= stylesheet_link_tag "application", "data-turbo-track": Rails.env.development? ? "" : "reload" %>
9+
<%= stylesheet_link_tag current_user.present? ? "application" : "public", "data-turbo-track": Rails.env.development? ? "" : "reload" %>
1010
<%= javascript_include_tag "application", "data-turbo-track": Rails.env.development? ? "" : "reload", defer: true %>
1111

1212
<%= csrf_meta_tags %>
@@ -16,7 +16,7 @@
1616
<%= yield :head %>
1717
</head>
1818

19-
<body class="nhsuk-template__body<%= ' app-signed-in' if current_user.present? %>">
19+
<body class="nhsuk-template__body">
2020
<script>
2121
document.body.className += ' js-enabled' +
2222
('noModule' in HTMLScriptElement.prototype

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
"workbox-build": "^7.3.0"
1515
},
1616
"scripts": {
17-
"build:css": "sass ./app/assets/stylesheets/application.scss:./app/assets/builds/application.css --no-source-map --pkg-importer=node --quiet-deps --style compressed",
17+
"build:css": "sass ./app/assets/stylesheets:./app/assets/builds --no-source-map --pkg-importer=node --quiet-deps --style compressed",
1818
"build": "esbuild app/javascript/*.[jt]s app/javascript/controllers/*.[jt]s --bundle --sourcemap --outdir=app/assets/builds --public-path=assets --minify",
1919
"build:serviceworker": "esbuild app/javascript/serviceworker/main.js --bundle --sourcemap --outfile=public/sw.js --minify",
2020
"test:e2e": "PW_EXPERIMENTAL_SERVICE_WORKER_NETWORK_EVENTS=1 playwright test",

0 commit comments

Comments
 (0)