Merge pull request #6685 from NHSDigital/dependabot/bundler/next/rubocop-govuk-5.2.1

Bump rubocop-govuk from 5.2.0 to 5.2.1

Author: thomasleese

Gemfile.lock

@@ -540,7 +540,7 @@ GEM
     parallel (1.28.0)
     parallel_tests (5.7.0)
       parallel
-    parser (3.3.10.2)
+    parser (3.3.11.1)
       ast (~> 2.4.1)
       racc
     pg (1.6.3-arm64-darwin)
@@ -701,26 +701,26 @@ GEM
       rspec-mocks (~> 3.0)
       sidekiq (>= 5, < 9)
     rspec-support (3.13.7)
-    rubocop (1.82.1)
+    rubocop (1.86.0)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.48.0, < 2.0)
+      rubocop-ast (>= 1.49.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.49.0)
+    rubocop-ast (1.49.1)
       parser (>= 3.3.7.2)
       prism (~> 1.7)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-govuk (5.2.0)
-      rubocop (= 1.82.1)
-      rubocop-ast (= 1.49.0)
+    rubocop-govuk (5.2.1)
+      rubocop (= 1.86.0)
+      rubocop-ast (= 1.49.1)
       rubocop-capybara (= 2.22.1)
       rubocop-rails (= 2.34.3)
       rubocop-rake (= 0.7.1)
@@ -780,7 +780,7 @@ GEM
       logger (>= 1.7.0)
       rack (>= 3.2.0)
       redis-client (>= 0.26.0)
-    sidekiq-scheduler (6.0.1)
+    sidekiq-scheduler (6.0.2)
       rufus-scheduler (~> 3.2)
       sidekiq (>= 7.3, < 9)
     sidekiq-throttled (2.1.0)

app/controllers/draft_schools_controller.rb

@@ -231,7 +231,7 @@ def update_params
         address_town
         address_postcode
       ],
-      year_groups: [year_groups: []],
+      year_groups: [{ year_groups: [] }],
       confirm: []
     }.fetch(current_step)
 

app/validators/nhs_number_validator.rb

@@ -27,7 +27,7 @@ def validate_each(record, attribute, value)
         digits
           .slice(0, 9)
           .each_with_index
-          .map { |digit, index| ((11 - (index + 1)) * digit) }
+          .map { |digit, index| (11 - (index + 1)) * digit }
 
       digits_sum_remainder = digits_multiplied_by_weighting_factor.sum % 11