Fetch location positions on creation

When creating new locations, either via onboarding a new team or by
explicitly creating a new clinic, we should fetch the position of the
location so that it's up to date.

I've intentionally not done this after the GIAS import as we have a job
that runs overnight which collects any locations that have an address
and no location so these will eventually be up to date.

Jira-Issue: MAV-6379

Author: thomasleese

app/lib/mavis_cli/clinics/create.rb

@@ -26,14 +26,17 @@ def call(
       )
         MavisCLI.load_rails
 
-        Location.create!(
-          type: :community_clinic,
-          name:,
-          address_line_1:,
-          address_town:,
-          address_postcode:,
-          ods_code:
-        )
+        location =
+          Location.create!(
+            type: :community_clinic,
+            name:,
+            address_line_1:,
+            address_town:,
+            address_postcode:,
+            ods_code:
+          )
+
+        LocationPositionUpdaterJob.perform_async(location.id)
       end
     end
   end

app/models/onboarding.rb

@@ -249,6 +249,10 @@ def save!(include_previous_academic_year: false)
       end
 
       PatientTeamUpdater.call(team_scope: Team.where(id: team.id))
+
+      location_ids =
+        schools.map(&:id) + clinics.keys.filter(&:has_address?).map(&:id)
+      LocationPositionUpdaterJob.perform_bulk(location_ids.zip)
     end
   end
 
@@ -311,7 +315,7 @@ def location
       @location ||= Location.gias_school.find_by_urn_and_site(urn)
     end
 
-    delegate :status, to: :location, allow_nil: true
+    delegate :id, :status, to: :location, allow_nil: true
     delegate :team, to: :subteam
 
     def save!
@@ -347,6 +351,8 @@ class NewSchoolSite
     validates :name, presence: true
     validates :site, presence: true
 
+    delegate :id, to: :location
+
     def original_location
       @original_location ||= Location.gias_school.find_by_urn_and_site(urn)
     end

spec/features/cli_clinics_create_spec.rb

@@ -7,6 +7,7 @@
     it "runs successfully" do
       when_i_run_the_command
       then_the_clinic_is_created
+      and_a_location_position_updater_job_is_enqueued
     end
   end
 
@@ -29,4 +30,10 @@ def then_the_clinic_is_created
     expect(clinic.address_town).to eq("Town")
     expect(clinic.address_postcode).to eq("SW1A 1AA")
   end
+
+  def and_a_location_position_updater_job_is_enqueued
+    expect(LocationPositionUpdaterJob).to have_enqueued_sidekiq_job(
+      Location.last.id
+    )
+  end
 end

spec/models/onboarding_spec.rb

@@ -71,10 +71,16 @@
       clinic1 = subteam1.community_clinics.find_by!(ods_code: nil)
       expect(clinic1.name).to eq("10 Downing Street")
       expect(clinic1.address_postcode).to eq("SW1A 1AA")
+      expect(LocationPositionUpdaterJob).to have_enqueued_sidekiq_job(
+        clinic1.id
+      )
 
       clinic2 = subteam2.community_clinics.find_by!(ods_code: "SW1A11")
       expect(clinic2.name).to eq("11 Downing Street")
       expect(clinic2.address_postcode).to eq("SW1A 1AA")
+      expect(LocationPositionUpdaterJob).to have_enqueued_sidekiq_job(
+        clinic2.id
+      )
     end
   end