Only send notifications to children that should have notifications sent

This had likely never been noticed before as the message has only been sent
roughly 500 times when sourced from a historical upload. For issues imported
through FHIR Imms they will frequently be recent vaccinations and therefore not
frequently to children that are invalidated, deceased, or restricted.

Jira-Issue: MAV-3284

Author: MartinVanIJcken

app/lib/notification_parent_selector.rb

@@ -3,21 +3,14 @@
 class NotificationParentSelector
   def initialize(vaccination_record:, consents: nil)
     @vaccination_record = vaccination_record
-
     @consents =
-      if consents.present?
-        consents
+      if @vaccination_record.patient.send_notifications?(
+           team: @vaccination_record.team,
+           send_to_archived: true
+         ) && @vaccination_record.notify_parents
+        consents || @vaccination_record.patient.consents
       else
-        patient = @vaccination_record.patient
-
-        if patient.send_notifications?(
-             team: @vaccination_record.team,
-             send_to_archived: true
-           ) && @vaccination_record.notify_parents
-          patient.consents
-        else
-          []
-        end
+        []
       end
   end
 

spec/lib/notification_parent_selector_spec.rb

@@ -173,15 +173,21 @@
     end
 
     context "when patient should not send notifications" do
-      let(:consents) { nil }
-
       before do
         allow(patient).to receive(:send_notifications?).and_return(false)
       end
 
       it "returns empty array" do
         expect(parents).to be_empty
       end
+
+      context "when no consents are provided" do
+        let(:consents) { nil }
+
+        it "returns empty array" do
+          expect(parents).to be_empty
+        end
+      end
     end
 
     context "edge cases" do