Skip to content

Commit dbd8ea8

Browse files
Move dfe-schools.zip and remove other unused files
These schools and GP data are long out of date so we should not be including them in our repository any more. They are downloaded on demand via the mavis CLI. We keep this old dfe-schools.zip as the data contained in it is used by the end-to-end tests. It is moved to be in a testing related folder instead. The imms api missing records explicilty states in its PR description that it can be removed after the data migration has been ran so it is removed too. Jira-Issue: MAV-496
1 parent 7375177 commit dbd8ea8

6 files changed

Lines changed: 8 additions & 286 deletions

File tree

.github/workflows/create_dockerized_db.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ jobs:
6363
run: |
6464
bin/rails db:setup
6565
bin/rails feature_flags:enable_for_development
66-
bin/mavis gias import
66+
bin/mavis gias import --input-file=spec/fixtures/dfe-schools.zip
6767
- name: Configure AWS Credentials
6868
uses: aws-actions/configure-aws-credentials@v5
6969
with:
@@ -81,4 +81,4 @@ jobs:
8181
run: |
8282
docker commit database "${{ steps.login-ecr.outputs.registry }}/mavis/development/postgres_db:${{ steps.github-ref.outputs.ref }}"
8383
- name: Push image
84-
run: docker push "${{ steps.login-ecr.outputs.registry }}/mavis/development/postgres_db:${{ steps.github-ref.outputs.ref }}"
84+
run: docker push "${{ steps.login-ecr.outputs.registry }}/mavis/development/postgres_db:${{ steps.github-ref.outputs.ref }}"

.gitignore

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -85,3 +85,8 @@ public/ref
8585

8686
# Redis
8787
dump.rdb
88+
89+
90+
# Data that gets downloaded by CLI tools
91+
db/data/dfe-schools.zip
92+
db/data/nhs-gp-practices.zip

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -226,7 +226,7 @@ This runs tests in the `end_to_end` rails environment which will not interfere w
226226
```shell
227227
RAILS_ENV=end_to_end bin/rails db:setup
228228
RAILS_ENV=end_to_end bin/rails feature_flags:enable_for_development
229-
RAILS_ENV=end_to_end bin/mavis gias import
229+
RAILS_ENV=end_to_end bin/mavis gias import --input-file=spec/fixtures/dfe-schools.zip
230230
RAILS_ENV=end_to_end bin/rails assets:precompile
231231
```
232232

0 commit comments

Comments
 (0)