Merge pull request #6606 from NHSDigital/alistair/imports-date-validations

Improve date validations on imports

Author: alistair-white-horne-tng

app/lib/csv_parser.rb

@@ -41,7 +41,8 @@ def to_date
 
         parsed_values =
           DATE_FORMATS.lazy.filter_map do |format|
-            Date.strptime(value, format)
+            date = Date.strptime(value, format)
+            date.year >= 1000 ? date : nil
           rescue ArgumentError, TypeError
             nil
           end

app/models/immunisation_import_row.rb

@@ -930,6 +930,11 @@ def validate_patient_date_of_birth
         patient_date_of_birth.header,
         "Enter a date of birth in the past."
       )
+    elsif patient_date_of_birth.to_date < Date.new(2000, 1, 1)
+      errors.add(
+        patient_date_of_birth.header,
+        "is too old to still be in school"
+      )
     end
   end
 

spec/lib/csv_parser/field_spec.rb

@@ -0,0 +1,81 @@
+# frozen_string_literal: true
+
+describe CSVParser::Field do
+  describe "#to_date" do
+    subject(:to_date) { field.to_date }
+
+    let(:field) { described_class.new(value, "A", 2, "date") }
+
+    context "when value is nil" do
+      let(:value) { nil }
+
+      it { should be_nil }
+    end
+
+    context "when value is blank" do
+      let(:value) { "" }
+
+      it { should be_nil }
+    end
+
+    context "when value is not a date" do
+      let(:value) { "not a date" }
+
+      it { should be_nil }
+    end
+
+    context "with format DD/MM/YYYY" do
+      let(:value) { "01/02/2025" }
+
+      it { should eq(Date.new(2025, 2, 1)) }
+    end
+
+    context "with format YYYY-MM-DD" do
+      let(:value) { "2025-02-01" }
+
+      it { should eq(Date.new(2025, 2, 1)) }
+    end
+
+    context "with format YYYYMMDD" do
+      let(:value) { "20250201" }
+
+      it { should eq(Date.new(2025, 2, 1)) }
+    end
+
+    context "with format DD/MM/YY (2-digit year)" do
+      let(:value) { "01/02/25" }
+
+      it { should be_nil }
+    end
+
+    context "with format YY-MM-DD (2-digit year)" do
+      let(:value) { "25-02-01" }
+
+      it { should be_nil }
+    end
+
+    context "with format YYMMDD (2-digit year)" do
+      let(:value) { "250201" }
+
+      it { should be_nil }
+    end
+
+    context "with a 3-digit year" do
+      let(:value) { "01/02/999" }
+
+      it { should be_nil }
+    end
+
+    context "with an impossible date" do
+      let(:value) { "31/02/2025" }
+
+      it { should be_nil }
+    end
+
+    context "with an invalid month" do
+      let(:value) { "01/13/2025" }
+
+      it { should be_nil }
+    end
+  end
+end

spec/models/immunisation_import_row_spec.rb

@@ -446,7 +446,29 @@
         end
       end
 
-      context "with an invalid patient date of birth" do
+      context "with a blank patient date of birth" do
+        let(:data) { { "PERSON_DOB" => "" } }
+
+        it "has errors" do
+          expect(immunisation_import_row).to be_invalid
+          expect(immunisation_import_row.errors["PERSON_DOB"]).to eq(
+            ["Enter a date of birth."]
+          )
+        end
+      end
+
+      context "with an unparseable patient date of birth" do
+        let(:data) { { "PERSON_DOB" => "not-a-date" } }
+
+        it "has errors" do
+          expect(immunisation_import_row).to be_invalid
+          expect(immunisation_import_row.errors["PERSON_DOB"]).to eq(
+            ["Enter a date of birth in the correct format."]
+          )
+        end
+      end
+
+      context "with a patient date of birth in the future" do
         let(:data) { { "PERSON_DOB" => "21000101" } }
 
         it "has errors" do
@@ -457,6 +479,17 @@
         end
       end
 
+      context "with a patient date of birth before 2000-01-01" do
+        let(:data) { { "PERSON_DOB" => "19991231" } }
+
+        it "has errors" do
+          expect(immunisation_import_row).to be_invalid
+          expect(immunisation_import_row.errors["PERSON_DOB"]).to eq(
+            ["is too old to still be in school"]
+          )
+        end
+      end
+
       context "when recording offline in to a clinic" do
         let(:valid_clinic_data) do
           valid_data.merge(