Set submitted_at on consents

When creating a consent (either by automatic matching with a consent
form, manual matching with a consent form, or when recording a verbal
consent), this ensures that the `submitted_at` column is set
approriately.

Author: thomasleese

app/models/consent.rb

@@ -150,6 +150,8 @@ def reasons_triage_needed
   end
 
   def self.from_consent_form!(consent_form, patient:, current_user:)
+    raise ConsentFormNotRecorded unless consent_form.recorded?
+
     ActiveRecord::Base.transaction do
       parent =
         consent_form.find_or_create_parent_with_relationship_to!(patient:)
@@ -165,7 +167,8 @@ def self.from_consent_form!(consent_form, patient:, current_user:)
             response: "given",
             route: "website",
             health_answers: consent_form.health_answers,
-            recorded_by: current_user
+            recorded_by: current_user,
+            submitted_at: consent_form.recorded_at
           )
         end
 
@@ -181,7 +184,8 @@ def self.from_consent_form!(consent_form, patient:, current_user:)
             response: "refused",
             route: "website",
             health_answers: consent_form.health_answers,
-            recorded_by: current_user
+            recorded_by: current_user,
+            submitted_at: consent_form.recorded_at
           )
         end
 
@@ -195,4 +199,7 @@ def notes_required?
     withdrawn? || invalidated? ||
       (response_refused? && !reason_for_refusal_personal_choice?)
   end
+
+  class ConsentFormNotRecorded < StandardError
+  end
 end

app/models/consent_form.rb

@@ -278,6 +278,10 @@ def wizard_steps
     ].compact
   end
 
+  def recorded?
+    recorded_at != nil
+  end
+
   def each_health_answer
     return if health_answers.empty?
     return to_enum(:each_health_answer) unless block_given?

app/models/draft_consent.rb

@@ -248,6 +248,7 @@ def write_to!(consent, triage:)
     super(consent)
 
     consent.parent = parent
+    consent.submitted_at ||= Time.current
 
     if triage_allowed? && response_given?
       triage.notes = triage_notes || ""

spec/factories/consents.rb

@@ -72,6 +72,8 @@
       end
     end
 
+    submitted_at { Time.current }
+
     traits_for_enum :response
 
     trait :given_verbally do

spec/jobs/consent_form_matching_job_spec.rb

@@ -7,6 +7,7 @@
   let(:consent_form) do
     create(
       :consent_form,
+      :recorded,
       session:,
       given_name: "John",
       family_name: "Smith",
@@ -70,6 +71,7 @@
       let(:consent_form) do
         create(
           :consent_form,
+          :recorded,
           session:,
           given_name: "john",
           family_name: "SMITH",

spec/models/consent_form_spec.rb

@@ -743,9 +743,25 @@
       create(:notify_log_entry, :email, consent_form:, patient: nil)
     end
 
+    context "when the consent form is draft" do
+      let(:consent_form) { create(:consent_form, organisation:, session:) }
+
+      it "raises an error" do
+        expect { match_with_patient! }.to raise_error(
+          Consent::ConsentFormNotRecorded
+        )
+      end
+    end
+
     context "when consent form confirms the school" do
       let(:consent_form) do
-        create(:consent_form, organisation:, session:, school_confirmed: true)
+        create(
+          :consent_form,
+          :recorded,
+          organisation:,
+          session:,
+          school_confirmed: true
+        )
       end
 
       it "creates a consent" do
@@ -763,10 +779,29 @@
       end
     end
 
+    context "when the consent form was submitted a week ago" do
+      let(:consent_form) do
+        create(
+          :consent_form,
+          recorded_at: 1.week.ago,
+          organisation:,
+          session:,
+          school_confirmed: true
+        )
+      end
+
+      it "creates a consent submitted a week ago" do
+        expect { match_with_patient! }.to change(Consent, :count).by(1)
+
+        expect(Consent.last.submitted_at).to eq(consent_form.recorded_at)
+      end
+    end
+
     context "when the patient goes to a different school" do
       let(:consent_form) do
         create(
           :consent_form,
+          :recorded,
           organisation:,
           session:,
           school_confirmed: false,
@@ -803,6 +838,7 @@
       let(:consent_form) do
         create(
           :consent_form,
+          :recorded,
           organisation:,
           session:,
           school_confirmed: nil,

spec/models/draft_consent_spec.rb

@@ -53,6 +53,23 @@
     end
   end
 
+  describe "#write_to" do
+    subject(:write_to) { draft_consent.write_to!(consent, triage:) }
+
+    let(:consent) { Consent.new }
+    let(:triage) { Triage.new }
+
+    let(:attributes) { valid_given_attributes }
+
+    it "sets the submitted at to today" do
+      freeze_time do
+        expect { write_to }.to change(consent, :submitted_at).from(nil).to(
+          Time.current
+        )
+      end
+    end
+  end
+
   describe "#reset_unused_fields" do
     subject(:save!) { draft_consent.save! }