Remove workaround for -immunization.target in Imms API requests

There used to be a couple of bugs in the API's `Bundle.link` where they used
`immunization.target` and `-immunization-target` instead of the expected
`-immunization.target`.

This has now been fixed in production, so we can remove our handling
of the bug.

Author: alistair-white-horne-tng

app/lib/nhs/immunisations_api.rb

@@ -408,34 +408,17 @@ def check_bundle_link_params(bundle, request_params)
       uri = URI(link)
       bundle_params = URI.decode_www_form(uri.query).to_h
 
-      # TODO: There is currently a bug in the API where the `Bundle.link` value for `-immunization.target` is
-      #       incorrectly returned as `immunization.target` rather than `-immunization.target`. Matt Jarvis has
-      #       told me that this should be fixed in their next release (3) or possibly release 4, at which point we
-      #       can remove this logic.
-      tweaked_bundle_params =
-        bundle_params.transform_keys do |key|
-          key == "immunization.target" ? "-immunization.target" : key
-        end
-      # TODO: They recently introduced another bug (presumably in the process of fixing their old bug), where they
-      #       now use `immunization-target`. This has only been seen in their staging environment, and we have notified
-      #       them, so hopefully this never reaches production. In the meantime we need to be able to test and demo
-      #       against their INT environment, and need to be robust against this bug in case it makes its way into prod.
-      tweaked_bundle_params =
-        tweaked_bundle_params.transform_keys do |key|
-          key == "immunization-target" ? "-immunization.target" : key
-        end
-
       # We don't care about the order of the target values
-      tweaked_bundle_params["-immunization.target"] = tweaked_bundle_params[
+      bundle_params["-immunization.target"] = bundle_params[
         "-immunization.target"
       ]&.split(",")&.sort
       request_params["-immunization.target"] = request_params[
         "-immunization.target"
       ].split(",").sort
 
-      unless tweaked_bundle_params == request_params
+      unless bundle_params == request_params
         message =
-          "Bundle link parameters do not match request parameters: #{tweaked_bundle_params} != #{request_params}"
+          "Bundle link parameters do not match request parameters: #{bundle_params} != #{request_params}"
         Rails.logger.warn(message)
         if Flipper.enabled?(:imms_api_sentry_warnings)
           Sentry.capture_exception(BundleLinkParamsMismatch.new(message))

spec/fixtures/files/fhir/search_response_0_results.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [],

spec/fixtures/files/fhir/search_response_1_result.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_1_result_mavis.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_1_result_mmrv.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://internal-dev.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?immunization.target=MMRV%2CMMR%2C3IN1%2CMENACWY%2CFLU%2CHPV&-immunization.target=MMRV%2CMMR%2C3IN1%2CMENACWY%2CFLU%2CHPV&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9990001855"
+      "url": "https://internal-dev.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?-immunization.target=MMRV%2CMMR%2C3IN1%2CMENACWY%2CFLU%2CHPV&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9990001855"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_2_results.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_2_results_mavis_duplicate.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=FLU,HPV,MENACWY,3IN1,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_2_results_mavis_duplicate_primary_source.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?immunization.target=3IN1,FLU,HPV,MENACWY,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/Immunization?-immunization.target=3IN1,FLU,HPV,MENACWY,MMR\u0026patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_all_programmes.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?immunization.target=FLU,HPV,MENACWY,MMR,3IN1&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?-immunization.target=FLU,HPV,MENACWY,MMR,3IN1&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [

spec/fixtures/files/fhir/search_response_all_programmes_mmrv.json

@@ -4,7 +4,7 @@
   "link": [
     {
       "relation": "self",
-      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?immunization.target=MMRV,FLU,HPV,MENACWY,MMR,3IN1&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
+      "url": "https://int.api.service.nhs.uk/immunisation-fhir-api/FHIR/R4/Immunization?-immunization.target=MMRV,FLU,HPV,MENACWY,MMR,3IN1&patient.identifier=https%3A%2F%2Ffhir.nhs.uk%2FId%2Fnhs-number%7C9449308357"
     }
   ],
   "entry": [