Remove redundant policy scoping

The prometheus and cloudwatch agent configs are ssmParameters not secrets

Author: TheOneFromNorway

terraform/app/iam_policy_documents.tf

@@ -30,7 +30,7 @@ data "aws_iam_policy_document" "ecs_secrets_access" {
     content {
       sid       = "dbSecretSid"
       actions   = ["secretsmanager:GetSecretValue"]
-      resources = concat([for kv_pair in local.secret_values[each.key] : kv_pair["valueFrom"]], [aws_ssm_parameter.prometheus_config.arn, aws_ssm_parameter.cloudwatch_agent_config.arn])
+      resources = [for kv_pair in local.secret_values[each.key] : kv_pair["valueFrom"]]
       effect    = "Allow"
     }
   }

terraform/app/ssm_parameters.tf

@@ -36,5 +36,7 @@ resource "aws_ssm_parameter" "cloudwatch_agent_config" {
   type        = "String"
   tier        = "Intelligent-Tiering"
   description = "CWAgent SSM Parameter for ECS Cluster: ${aws_ecs_cluster.cluster.name}"
-  value       = templatefile("templates/cloudwatch_agent_config.json.tpl", { log_group_name = aws_cloudwatch_log_group.ecs_log_group.name })
+  value = templatefile("templates/cloudwatch_agent_config.json.tpl", {
+    log_group_name = aws_cloudwatch_log_group.ecs_log_group.name
+  })
 }