Fix for consent confirmation comms not appearing in the activity log

Jira-Issue: MAV-5062

Author: benilovj

app/lib/govuk_notify_personalisation.rb

@@ -25,7 +25,9 @@ def initialize(
     @consent = consent
     @consent_form = consent_form
     @parent = parent || consent&.parent
-    @patient = patient || consent&.patient || vaccination_record&.patient
+    @patient =
+      patient || consent&.patient || vaccination_record&.patient ||
+        Patient.find_by(id: consent_form&.matched_patient&.id)
     @session = session || consent_form&.session || vaccination_record&.session
     @team =
       team || session&.team || consent_form&.team || consent&.team ||

spec/features/parental_consent_inexact_auto_match_spec.rb

@@ -121,5 +121,6 @@ def and_they_see_consent_contact_warning_notifications
     expect(page).to have_content("Consent unknown contact details warning sent")
     expect(page).to have_content(@parent.email)
     expect(page).to have_content(@parent.phone)
+    expect(page).to have_content("Consent confirmation given sent")
   end
 end

spec/jobs/email_delivery_job_spec.rb

@@ -206,6 +206,24 @@
         expect(notify_log_entry.programmes.map(&:type)).to eq(programme_types)
       end
 
+      context "when the consent form is matched to a patient" do
+        let(:matched_patient) { create(:patient) }
+
+        before do
+          create(
+            :consent,
+            programme: session.programmes.first,
+            consent_form:,
+            patient: matched_patient
+          )
+        end
+
+        it "sets patient on the log entry from the matched consent form" do
+          perform_now
+          expect(NotifyLogEntry.last.patient).to eq(matched_patient)
+        end
+      end
+
       context "when the parent doesn't have a phone number" do
         let(:consent_form) do
           create(:consent_form, session:, parent_email: nil)