Merge pull request #5691 from nhsuk/revert-upload-only-team-year-groups

Revert "Set Team.year_groups statically for upload-only teams"

Author: alistair-white-horne-tng

app/models/team.rb

@@ -45,8 +45,6 @@ class ActiveRecord_Relation < ActiveRecord::Relation
     include ContributesToPatientTeams::Relation
   end
 
-  UPLOAD_ONLY_YEAR_GROUPS = (-2..13).to_a.freeze
-
   audited associated_with: :organisation
   has_associated_audits
 
@@ -97,8 +95,6 @@ class ActiveRecord_Relation < ActiveRecord::Relation
   def to_param = workgroup
 
   def year_groups(academic_year: nil)
-    return UPLOAD_ONLY_YEAR_GROUPS if has_upload_only_access?
-
     academic_year ||= AcademicYear.pending
     location_programme_year_groups
       .joins(:location_year_group)

spec/models/team_spec.rb

@@ -64,18 +64,4 @@
 
   it_behaves_like "a model with a normalised email address"
   it_behaves_like "a model with a normalised phone number"
-
-  describe "#year_groups" do
-    context "when team has upload_only access" do
-      let(:team) { create(:team, type: :upload_only) }
-
-      it "covers nursery to upper sixth" do
-        expect(team.year_groups).to eq((-2..13).to_a)
-      end
-
-      it "ignores academic_year parameter" do
-        expect(team.year_groups(academic_year: 2024)).to eq((-2..13).to_a)
-      end
-    end
-  end
 end