Refactor q -> query

Our linter rules include a provision that method parameters should not have
fewer than 3 characters.  The parameter `q` does not satisfy this. The issue was
previously hidden as `q` always got passed indirectly by unpacking `parameters`.
Now that the query is explicitly a parameter of PatientFilter, the linter is
able to pick up on this style violation.

Author: MartinVanIJcken

app/components/app_location_search_form_component.html.erb

@@ -2,7 +2,7 @@
   <%= render AppCardComponent.new(filters: true) do |card| %>
     <% card.with_heading(level: 2) { "Find school" } %>
 
-    <%= render AppSearchInputComponent.new(name: :q, value: form.q, label: { hidden: true }) %>
+    <%= render AppSearchInputComponent.new(name: :query, value: form.query, label: { hidden: true }) %>
 
     <%= f.govuk_radio_buttons_fieldset :phase,
                                        legend: { text: "Phase", size: "s" },

app/components/app_patient_search_form_component.html.erb

@@ -3,8 +3,8 @@
     <% card.with_heading(level: heading_level) { "Find children" } %>
 
     <%= render AppSearchInputComponent.new(
-          name: :q,
-          value: form.q,
+          name: :query,
+          value: form.query,
           label: { hidden: true },
         ) %>
 

app/components/app_session_search_form_component.html.erb

@@ -2,7 +2,7 @@
   <%= render AppCardComponent.new(filters: true) do |card| %>
     <% card.with_heading(level: 2) { "Find session" } %>
 
-    <%= render AppSearchInputComponent.new(name: :q, value: form.q, label: { hidden: true }) %>
+    <%= render AppSearchInputComponent.new(name: :query, value: form.query, label: { hidden: true }) %>
 
     <% if programmes.present? %>
       <%= f.govuk_check_boxes_fieldset :programmes,

app/controllers/concerns/location_search_form_concern.rb

@@ -17,6 +17,6 @@ def set_location_search_form
   private
 
   def location_search_form_params
-    params.permit(:_clear, :phase, :q)
+    params.permit(:_clear, :phase, :query)
   end
 end

app/controllers/concerns/patient_search_form_concern.rb

@@ -30,7 +30,7 @@ def patient_search_form_params
       :missing_nhs_number,
       :patient_specific_direction_status,
       :programme_status_group,
-      :q,
+      :query,
       :registration_status,
       programme_statuses: [],
       programme_types: [],

app/controllers/concerns/session_search_form_concern.rb

@@ -17,6 +17,13 @@ def set_session_search_form
   private
 
   def session_search_form_params
-    params.permit(:_clear, :academic_year, :q, :status, :type, programmes: [])
+    params.permit(
+      :_clear,
+      :academic_year,
+      :query,
+      :status,
+      :type,
+      programmes: []
+    )
   end
 end

app/controllers/draft_vaccination_records_controller.rb

@@ -306,7 +306,7 @@ def set_batches
 
   def set_locations
     if @draft_vaccination_record.national_reporting_user_and_record?
-      @location_query = params[:q]
+      @location_query = params[:query]
       scope = Location.gias_school.where(status: "open")
 
       if @location_query.present?

app/forms/location_search_form.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class LocationSearchForm < SearchForm
-  attribute :q, :string
+  attribute :query, :string
   attribute :phase, :string
 
   def apply(scope)
@@ -18,6 +18,6 @@ def filter_phase(scope)
   end
 
   def filter_name(scope)
-    q.present? ? scope.search_by_name(q) : scope
+    query.present? ? scope.search_by_name(query) : scope
   end
 end

app/forms/patient_search_form.rb

@@ -14,7 +14,7 @@ class PatientSearchForm < SearchForm
   attribute :programme_status_group, :string
   attribute :programme_statuses, array: true
   attribute :programme_types, array: true
-  attribute :q, :string
+  attribute :query, :string
   attribute :registration_status, :string
   attribute :vaccine_criteria, array: true
   attribute :year_groups, array: true
@@ -58,6 +58,11 @@ def academic_year
   def team = session&.team || current_team
 
   def filter
-    PatientFilter.new(team:, session:, academic_year:, **attributes.symbolize_keys)
+    PatientFilter.new(
+      team:,
+      session:,
+      academic_year:,
+      **attributes.symbolize_keys
+    )
   end
 end

app/forms/session_search_form.rb

@@ -3,7 +3,7 @@
 class SessionSearchForm < SearchForm
   attribute :academic_year, :integer
   attribute :programmes, array: true
-  attribute :q, :string
+  attribute :query, :string
   attribute :status, :string
   attribute :type, :string
 
@@ -34,7 +34,7 @@ def filter_programmes(scope)
   end
 
   def filter_name(scope)
-    q.present? ? scope.search_by_name(q) : scope
+    query.present? ? scope.search_by_name(query) : scope
   end
 
   def filter_type(scope)