Skip to content

Commit aa45c29

Browse files
Merge pull request #5764 from nhsuk/mike/remove-reports-card-in-national-reporting
Remove reports card from national reporting dashboard
2 parents 933d653 + b3e1a86 commit aa45c29

3 files changed

Lines changed: 4 additions & 22 deletions

File tree

app/controllers/dashboard_controller.rb

Lines changed: 3 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,18 +23,13 @@ def set_primary_items
2323
title: I18n.t("imports.index.title"),
2424
path: imports_path,
2525
description: I18n.t("imports.index.description_upload_only"),
26-
width: "one-third"
26+
width: "one-half"
2727
},
2828
{
2929
title: I18n.t("patients.index.title"),
3030
path: patients_path,
3131
description: I18n.t("patients.index.description_upload_only"),
32-
width: "one-third"
33-
},
34-
{
35-
title: I18n.t("reports.index.title"),
36-
description: I18n.t("reports.index.description_upload_only"),
37-
width: "one-third"
32+
width: "one-half"
3833
}
3934
]
4035
else
@@ -70,7 +65,7 @@ def set_primary_items
7065
def set_secondary_items
7166
@secondary_items = []
7267

73-
unless current_team.has_upload_only_access?
68+
if current_team.has_poc_only_access?
7469
@secondary_items << {
7570
title: I18n.t("school_moves.index.title"),
7671
path: school_moves_path,

config/locales/en.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -734,7 +734,6 @@ en:
734734
index:
735735
title: Reports
736736
description: View the progress of vaccination programmes and download vaccination data
737-
description_upload_only: View statistics on vaccinations given by vaccine, gender and year group
738737
school_moves:
739738
index:
740739
title: School moves

spec/features/upload_only_team_spec.rb

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
then_i_should_see_the_upload_only_cards
88
and_i_should_see_the_import_records_card
99
and_i_should_see_the_children_card
10-
and_i_should_see_the_reports_card
1110
and_i_should_see_the_national_reporting_service_name
1211
end
1312

@@ -83,7 +82,7 @@ def when_i_visit_the_dashboard
8382

8483
def then_i_should_see_the_upload_only_cards
8584
cards = page.all(".nhsuk-card-group__item")
86-
expect(cards.count).to eq(4)
85+
expect(cards.count).to eq(3)
8786
end
8887

8988
def and_i_should_see_the_import_records_card
@@ -105,17 +104,6 @@ def and_i_should_see_the_children_card
105104
expect(card).to have_link("Children", href: patients_path)
106105
end
107106

108-
def and_i_should_see_the_reports_card
109-
cards = page.all(".nhsuk-card-group__item")
110-
card = cards[2]
111-
112-
expect(card).to have_css("h2", text: "Reports")
113-
expect(card).not_to have_link("Reports")
114-
115-
# Card should be disabled
116-
expect(card).to have_css(".app-card--disabled")
117-
end
118-
119107
def then_i_should_see_only_import_children_and_team_navigation_items
120108
navigation_items = page.all(".nhsuk-header__navigation-item")
121109
expect(navigation_items.count).to eq(2)

0 commit comments

Comments
 (0)