Merge pull request #5999 from nhsuk/feature-flag-ethnicity-questions

Add feature flag for ethnicity capture

Author: jhenderson

app/controllers/parent_interface/consent_forms_controller.rb

@@ -67,10 +67,14 @@ def record
       # onto the matched patient.
       ProcessConsentFormJob.perform_later(@consent_form.id)
 
-      redirect_to parent_interface_consent_form_edit_path(
-                    @consent_form,
-                    "ethnicity"
-                  )
+      if Flipper.enabled?(:ethnicity_capture)
+        redirect_to parent_interface_consent_form_edit_path(
+                      @consent_form,
+                      "ethnicity"
+                    )
+      else
+        redirect_to submitted_parent_interface_consent_form_path(@consent_form)
+      end
     end
 
     def submitted

app/models/consent_form.rb

@@ -362,7 +362,8 @@ def wizard_steps
             :reason_for_refusal_notes
           end
         )
-      ].compact + (recorded? ? ETHNICITY_STEPS : [])
+      ].compact +
+      (Flipper.enabled?(:ethnicity_capture) && recorded? ? ETHNICITY_STEPS : [])
   end
 
   def recorded? = recorded_at != nil

config/feature_flags.yml

@@ -3,6 +3,8 @@ basic_auth: Require users to sign in with basic authentication before they
 
 dev_tools: Developer tools useful for testing and debugging.
 
+ethnicity_capture: Enable optional ethnicity capture after parent consent
+
 imms_api_enqueue_rolling_searches: |
   Enables enqueueing of vaccination searches for patients not in sessions,
   spread over a period of 28 days, in the EnqueueVaccinationsSearchInNHSJob.

spec/features/parental_consent_change_answers_spec.rb

@@ -300,6 +300,8 @@ def and_i_choose_my_phone_contact_method
   end
 
   def and_i_refuse_to_answer_questions_on_ethnicity
+    return unless Flipper.enabled?(:ethnicity_capture)
+
     choose "No, skip the ethnicity questions"
     click_on "Continue"
   end

spec/features/parental_consent_clinic_spec.rb

@@ -301,6 +301,8 @@ def then_the_nurse_should_see_unknown_school
   end
 
   def and_i_refuse_to_answer_questions_on_ethnicity
+    return unless Flipper.enabled?(:ethnicity_capture)
+
     choose "No, skip the ethnicity questions"
     click_on "Continue"
   end

spec/features/parental_consent_create_patient_spec.rb

@@ -213,6 +213,8 @@ def then_the_patient_should_be_safe_to_vaccinate
   end
 
   def and_i_refuse_to_answer_questions_on_ethnicity
+    return unless Flipper.enabled?(:ethnicity_capture)
+
     choose "No, skip the ethnicity questions"
     click_on "Continue"
   end

spec/features/parental_consent_different_school_spec.rb

@@ -140,6 +140,8 @@ def then_i_see_the_confirmation_page
   end
 
   def and_i_refuse_to_answer_questions_on_ethnicity
+    return unless Flipper.enabled?(:ethnicity_capture)
+
     choose "No, skip the ethnicity questions"
     click_on "Continue"
   end

spec/features/parental_consent_flu_spec.rb

@@ -1,6 +1,8 @@
 # frozen_string_literal: true
 
 describe "Parental consent" do
+  before { given_ethnicity_capture_is_enabled }
+
   scenario "Flu" do
     given_a_flu_programme_is_underway
     when_i_go_to_the_consent_form
@@ -82,6 +84,10 @@
     then_the_psd_is_invalidated
   end
 
+  def given_ethnicity_capture_is_enabled
+    Flipper.enable(:ethnicity_capture)
+  end
+
   def given_a_flu_programme_is_underway
     @programme = Programme.flu
     @team = create(:team, :with_one_nurse, programmes: [@programme])

spec/features/parental_consent_hpv_spec.rb

@@ -214,6 +214,8 @@ def then_the_patient_should_be_safe_to_vaccinate
   end
 
   def and_i_refuse_to_answer_questions_on_ethnicity
+    return unless Flipper.enabled?(:ethnicity_capture)
+
     choose "No, skip the ethnicity questions"
     click_on "Continue"
   end

spec/features/parental_consent_inexact_auto_match_spec.rb

@@ -87,8 +87,10 @@ def when_a_parent_gives_consent_with_three_of_four_fields_matching_the_cohort
     expect(page).to have_content("Child’s nameJoanna Smith")
     click_on "Confirm"
 
-    choose "No, skip the ethnicity questions"
-    click_on "Continue"
+    if Flipper.enabled?(:ethnicity_capture)
+      choose "No, skip the ethnicity questions"
+      click_on "Continue"
+    end
 
     expect(page).to have_content(
       "Joanna Smith is due to get the HPV vaccination at school"