Populate school and location at same time

In the previous commit we added a `school_id` column which will
eventually replace the `location_id` column. This change ensures that
when saving or updating patient locations, we set the `school_id` column
matching the value of the `location_id` column. Once we're confident
both columns are being written to we will stop writing to `location_id`
and eventually remove it.

Jira-Issue: MAV-7114
Jira-Issue: MAV-7113

Author: thomasleese

app/lib/mavis_cli/schools/move_patients.rb

@@ -70,7 +70,7 @@ def call(source_urn:, target_urn:)
         PatientLocation.where(
           academic_year:,
           location_id: old_loc.id
-        ).update_all(location_id: new_loc.id)
+        ).update_all(location_id: new_loc.id, school_id: new_loc.id)
         ConsentForm.where(team_location_id: old_team_location.id).update_all(
           team_location_id: new_team_location.id
         )

app/lib/team_merger.rb

@@ -380,7 +380,8 @@ def migrate_generic_locations(merged_team)
           .where.not(id: patient_location_ids_to_keep)
           .delete_all
         PatientLocation.where(id: patient_location_ids_to_keep).update_all(
-          location_id: merged_loc.id
+          location_id: merged_loc.id,
+          school_id: merged_loc.id
         )
       end
 

app/models/patient_location.rb

@@ -37,6 +37,7 @@ class PatientLocation < ApplicationRecord
 
   belongs_to :patient
   belongs_to :location
+  belongs_to :school, class_name: "Location", optional: true
 
   has_and_belongs_to_many :immunisation_imports
 
@@ -84,6 +85,16 @@ class PatientLocation < ApplicationRecord
           )
         end
 
+  def location=(location)
+    super
+    self.school = location
+  end
+
+  def location_id=(location_id)
+    super
+    self.school_id = location_id
+  end
+
   def begin_date
     value = date_range.begin
     return nil if value.nil? || value == -Float::INFINITY

spec/jobs/enqueue_vaccinations_search_in_nhs_job_spec.rb

@@ -357,12 +357,12 @@ def setup_feature_flag
 
           Patient.import(build_list(:patient, 50, team:, school:, session:))
           PatientLocation.import(
-            Patient.all.map do
-              {
-                patient_id: it.id,
-                location_id: location.id,
+            Patient.all.map do |patient|
+              PatientLocation.new(
+                patient:,
+                location:,
                 academic_year: AcademicYear.pending
-              }
+              )
             end
           )
           PatientTeamUpdater.call

spec/models/patient_location_spec.rb

@@ -37,6 +37,16 @@
   let(:programme) { Programme.sample }
   let(:session) { create(:session, programmes: [programme]) }
 
+  describe "associations" do
+    it { should belong_to(:patient) }
+
+    it do
+      expect(patient_location).to belong_to(:school).class_name(
+        "Location"
+      ).optional(true)
+    end
+  end
+
   describe "scopes" do
     describe "#appear_in_programmes" do
       subject(:scope) do