Run PostGIS in test workflow

To be able to run the tests against a version of PostgreSQL that
supports PostGIS.

I've also renamed a few of the jobs and steps to make them clearer
what they do.

Jira-Issue: MAV-6379
Jira-Issue: MAV-6706

Author: thomasleese

…ithub/workflows/create_dockerized_db.yml …kflows/build-and-push-database-image.yml.github/workflows/create_dockerized_db.yml renamed to .github/workflows/build-and-push-database-image.yml .github/workflows/create_dockerized_db.yml renamed to .github/workflows/build-and-push-database-image.yml

@@ -1,11 +1,10 @@
-name: Create Dockerized Database
-run-name: Creating dockerized image from ${{ github.ref_name }}
+name: Build and push database image
+run-name: Build and push database image for ${{ github.ref_name }}
 
 on:
   workflow_dispatch:
   push:
-    branches:
-      - next
+    branches: [next]
   workflow_call:
     inputs:
       github_ref:
@@ -17,8 +16,8 @@ permissions:
   contents: read
 
 jobs:
-  setup-development-database:
-    name: Setup Development Database
+  build-and-push-database-image:
+    name: Build and push database image
     runs-on: ubuntu-latest
     env:
       RAILS_ENV: development
@@ -32,34 +31,36 @@ jobs:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
         with:
           ref: ${{ inputs.github_ref || github.ref_name == 'next' && 'next' || github.ref_name }}
-          repository: nhsuk/manage-vaccinations-in-schools
+          repository: nhsdigital/manage-vaccinations-in-schools
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
         with:
           node-version-file: .tool-versions
           cache: yarn
-      - name: Build custom postgres image
-        run: |
-          echo -e "FROM postgres:16.11\n\nENV PGDATA=\"/var/lib/postgresql/mydata\"" > db.Dockerfile
-          docker build -t custom-postgres:latest -f db.Dockerfile .
-      - name: Start db container
+      - name: Create Dockerfile
+        run: >-
+          echo -e \
+            "FROM postgis/postgis:17-master\nENV PGDATA=\"/var/lib/postgresql/mydata\"" \
+            > database.Dockerfile
+      - name: Build image
+        run: docker build -t database:latest -f database.Dockerfile .
+      - name: Start container
         run: |
           docker run -d \
             --name database \
             -e "POSTGRES_HOST_AUTH_METHOD=trust" \
             -p 5432:5432 \
-            custom-postgres:latest
-      - name: Wait for db to be ready
+            database:latest
+      - name: Wait for database to be ready
         run: |
           docker exec database bash -c '
             until pg_isready -U postgres; do
               echo "Waiting for postgres..."
               sleep 2
-            done
-                '
+            done'
       - uses: ruby/setup-ruby@60ecfba8750476ff216b59eee3b88218bb5111cc # v1.303.0
         with:
           bundler-cache: true
-      - name: Populate database for testing
+      - name: Set up database for testing
         run: |
           bin/rails db:setup
           bin/rails feature_flags:enable_for_development
@@ -73,17 +74,17 @@ jobs:
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@376925c9d111252e87ae59691e5a442dd100ef6a # v2.1.3
       # yamllint disable rule:line-length
-      - name: get github ref short
-        id: github-ref
+      - name: Get image tag
+        id: get-image-tag
         run: |
           git_ref=$(git rev-parse ${{ inputs.github_ref || github.ref_name == 'next' && 'origin/next' || github.ref_name }})
-          echo "ref=$git_ref" >> "$GITHUB_OUTPUT"
-      - name: Commit postgres container with database
+          echo "value=$git_ref" >> "$GITHUB_OUTPUT"
+      - name: Commit image
         run: >-
           docker commit database "${{ steps.login-ecr.outputs.registry
-          }}/mavis/development/postgres_db:${{ steps.github-ref.outputs.ref }}"
+          }}/mavis/development/postgres_db:${{ steps.get-image-tag.outputs.value }}"
       - name: Push image
         run: >-
           docker push "${{ steps.login-ecr.outputs.registry }}/mavis/development/postgres_db:${{
-          steps.github-ref.outputs.ref }}"
+          steps.get-image-tag.outputs.value }}"
       # yamllint enable rule:line-length

.github/workflows/end-to-end-tests-aws.yml

@@ -1,4 +1,4 @@
-name: AWS deployment E2E tests
+name: AWS
 
 on:
   workflow_call:
@@ -122,7 +122,7 @@ jobs:
     permissions:
       id-token: write
       contents: read
-    uses: ./.github/workflows/create_dockerized_db.yml
+    uses: ./.github/workflows/build-and-push-database-image.yml
     with:
       github_ref: ${{ needs.check-database-image-presence.outputs.db_git_ref_sha }}
   launch-dockerized-devimage:

.github/workflows/end-to-end-tests-local.yml

@@ -1,13 +1,13 @@
-name: Local E2E tests
+name: Local
 
 on: [workflow_call]
 
 jobs:
   end-to-end-tests:
     runs-on: ubuntu-latest
     services:
-      postgres:
-        image: postgres:17.2
+      postgresql:
+        image: postgis/postgis:17-master
         env:
           POSTGRES_PASSWORD: postgres
         options: >-

.github/workflows/end-to-end-tests-on-pull-request.yml

@@ -1,4 +1,4 @@
-name: E2E tests on PR
+name: End-to-end tests
 
 on: [pull_request]
 
@@ -11,7 +11,7 @@ permissions: {}
 jobs:
   aws-e2e-flow:
     if: github.event.pull_request.head.repo.full_name == github.repository
-    name: AWS deployment E2E tests
+    name: AWS
     permissions:
       id-token: write
       contents: write
@@ -22,7 +22,7 @@ jobs:
 
   local-e2e-flow:
     if: github.event.pull_request.head.repo.full_name != github.repository
-    name: Local E2E tests
+    name: Local
     uses: ./.github/workflows/end-to-end-tests-local.yml
 
   ensure-run-success:

.github/workflows/test.yml

@@ -11,8 +11,8 @@ jobs:
     name: RSpec
     runs-on: ubuntu-latest
     services:
-      postgres:
-        image: postgres:17.2
+      postgresql:
+        image: postgis/postgis:17-master
         env:
           POSTGRES_PASSWORD: postgres
         options: >-
@@ -50,8 +50,8 @@ jobs:
     name: Seeds
     runs-on: ubuntu-latest
     services:
-      postgres:
-        image: postgres:17.2
+      postgresql:
+        image: postgis/postgis:17-master
         env:
           POSTGRES_PASSWORD: postgres
         options: >-
@@ -60,7 +60,8 @@ jobs:
           - 5432:5432
     env:
       RAILS_ENV: development
-      DATABASE_URL: postgres://postgres:postgres@localhost:5432/manage_vaccinations_development
+      DATABASE_URL: >-
+        postgis://postgres:postgres@localhost:5432/manage_vaccinations_development
     steps:
       - uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
       - uses: actions/setup-node@53b83947a5a98c8d113130e565377fae1a50d02f # v6.3.0
@@ -70,7 +71,7 @@ jobs:
       - uses: ruby/setup-ruby@60ecfba8750476ff216b59eee3b88218bb5111cc # v1.303.0
         with:
           bundler-cache: true
-      - name: Check seeds run
+      - name: Run seeds
         run: bin/rails db:prepare
 
   jest:
@@ -82,5 +83,7 @@ jobs:
         with:
           node-version-file: .tool-versions
           cache: yarn
-      - run: yarn install --immutable --immutable-cache --check-cache
-      - run: yarn test
+      - name: Install dependencies
+        run: yarn install --immutable --immutable-cache --check-cache
+      - name: Run tests
+        run: yarn test