Merge pull request #6700 from NHSDigital/ensure-nicer-error-for-missing-careplus-url

Ensure more descriptive error appears when URL for mock careplus service isn't set

Author: jf-x-dev

app/lib/careplus/client.rb

@@ -16,8 +16,10 @@ def initialize(username:, password:, namespace:, payload:)
     end
 
     def send_csv
-      uri =
-        URI.parse("#{Settings.careplus.base_url}/#{namespace}/soap.SchImms.cls")
+      base_url = Settings.careplus.base_url.presence or
+        raise "Settings.careplus.base_url is empty or has not been configured " \
+                "(if this is a deployed service, the MOCK_CAREPLUS_URL environment variable may not be set)"
+      uri = URI.parse("#{base_url}/#{namespace}/soap.SchImms.cls")
       soap_body = build_soap_envelope
       post_soap_request(uri, soap_body)
     end

spec/lib/careplus/client_spec.rb

@@ -74,6 +74,14 @@
     end
   end
 
+  context "when base_url is not configured" do
+    before { allow(Settings.careplus).to receive(:base_url).and_return(nil) }
+
+    it "raises a RuntimeError" do
+      expect { response }.to raise_error(RuntimeError)
+    end
+  end
+
   context "when base_url uses HTTPS" do
     before do
       allow(Settings.careplus).to receive(:base_url).and_return(