Exclude discontinued vaccines from side-effects in comms

vaccine_side_effects was including side effects from discontinued
vaccines when building the union across a programme's vaccines. Filter
with .active in both VaccineCriteria#side_effects and the
no-patient fallback in GovukNotifyPersonalisation.

Jira-Issue: MAV-5902

Author: benilovj

app/lib/govuk_notify_personalisation.rb

@@ -478,7 +478,7 @@ def vaccine_side_effects
             patient.vaccine_criteria(programme:, academic_year:).side_effects
           end
         else
-          Vaccine.for_programmes(programmes).flat_map(&:side_effects)
+          Vaccine.for_programmes(programmes).active.flat_map(&:side_effects)
         end
       end
 

app/lib/vaccine_criteria.rb

@@ -46,6 +46,7 @@ def primary_method
   def side_effects
     Vaccine
       .for_programme(programme)
+      .active
       .where(method: primary_method)
       .flat_map(&:side_effects)
   end

spec/lib/govuk_notify_personalisation_spec.rb

@@ -852,6 +852,21 @@
             "- generally feeling unwell\n- swelling or pain where the injection was given"
         )
       end
+
+      context "when a vaccine is discontinued" do
+        before do
+          Vaccine
+            .for_programme(hpv_programme)
+            .first
+            .update!(discontinued: true, side_effects: %w[headache])
+        end
+
+        it "excludes side effects from the discontinued vaccine" do
+          expect(personalisation).not_to have_attributes(
+            vaccine_side_effects: a_string_matching("headache")
+          )
+        end
+      end
     end
 
     context "with a vaccination record" do
@@ -882,6 +897,21 @@
             "- generally feeling unwell\n- swelling or pain where the injection was given"
         )
       end
+
+      context "when a vaccine is discontinued" do
+        before do
+          Vaccine
+            .for_programme(hpv_programme)
+            .first
+            .update!(discontinued: true, side_effects: %w[headache])
+        end
+
+        it "excludes side effects from the discontinued vaccine" do
+          expect(personalisation).not_to have_attributes(
+            vaccine_side_effects: a_string_matching("headache")
+          )
+        end
+      end
     end
   end