Fix content in views when patient moving across teams

We were previously identifying the source team through the patient's school. This won't work when the patient is in nil school, we must use the patient's teams through locations here.

Author: murugapl

app/components/app_import_review_school_moves_summary_component.html.erb

@@ -37,10 +37,11 @@
             <%= destination_school_name(changeset) %>
           </span>
           <% if school_move_across_teams?(changeset) %>
+            <% source_team = changeset.patient.teams_via_patient_locations.first %>
             <div class="nhsuk-u-margin-top-1">
               <%= render(
                     AppStatusComponent.new(
-                      text: "This child is moving in from #{changeset.patient.school.teams.first.name}'s area",
+                      text: "This child is moving in from #{source_team.name}'s area",
                       small: true,
                       classes: "nhsuk-u-margin-top-1 nhsuk-u-margin-bottom-0",
                     )

app/components/app_import_review_school_moves_summary_component.rb

@@ -30,10 +30,13 @@ def destination_school(changeset)
   end
 
   def school_move_across_teams?(changeset)
-    patient = changeset.patient
     dest_school = destination_school(changeset)
 
-    dest_school && patient.school && patient.school.teams.any? &&
-      (dest_school.teams & patient.school.teams).empty?
+    current_teams = changeset.patient.teams_via_patient_locations
+    return false if current_teams.empty?
+
+    new_teams = dest_school&.teams || [changeset.import.team]
+
+    (new_teams & current_teams).empty?
   end
 end

app/components/app_patient_card_component.rb

@@ -92,15 +92,13 @@ def gillick_no_notify_notices
   end
 
   def team_changed_notices
-    return unless patient.school
-
     valid_notices =
       patient
         .important_notices
         .team_changed
         .includes(:school_move_log_entry)
         .where(team: current_team)
-        .where.not(team: patient.school.teams)
+        .where.not(team: patient.teams_via_patient_locations)
 
     valid_notices.map(&:message)
   end

app/views/school_moves/show.html.erb

@@ -19,8 +19,9 @@
       <% card.with_heading(level: 2) { "#{@school_move.human_enum_name(:source)} record" } %>
       <% if @school_move.from_another_team? %>
         <div class="nhsuk-u-margin-top-1">
+          <% source_team = @school_move.patient.teams_via_patient_locations.first %>
           <%= render AppStatusComponent.new(text: "Confirming this school move will bring #{@school_move.patient.given_name} " \
-                                            "into your area from #{@school_move.patient.school.teams.first.name}") %>
+                                            "into your area from #{source_team.name}") %>
         </div>
       <% end %>
       <%= render AppChildSummaryComponent.new(@patient_with_changes) %>

spec/components/app_import_review_component_spec.rb

@@ -124,6 +124,14 @@
       ]
     end
 
+    before do
+      create(
+        :patient_location,
+        patient: inter_team_patient,
+        location: other_location
+      )
+    end
+
     include_examples "section with details",
                      title:
                        "Children moving from another SAIS team's area - resolve after import",
@@ -155,6 +163,14 @@
       ]
     end
 
+    before do
+      create(
+        :patient_location,
+        patient: inter_team_patient,
+        location: other_location
+      )
+    end
+
     it "renders separate expander for close matches" do
       expect(rendered).to have_css(
         ".nhsuk-details__summary-text",

spec/components/app_import_review_school_moves_summary_component_spec.rb

@@ -113,6 +113,8 @@
       ]
     end
 
+    before { create(:patient_location, patient:, location: current_school) }
+
     it "displays inter-team move status message" do
       expect(rendered).to have_css(
         ".app-status",
@@ -326,6 +328,12 @@
 
     before do
       current_school.attach_to_team!(team2, academic_year:)
+      create(
+        :patient_location,
+        patient:,
+        location: current_school,
+        academic_year:
+      )
       changesets.first.data["review"]["school_move"] = {
         "school_id" => destination_school.id,
         "home_educated" => false

spec/components/app_patient_card_component_spec.rb

@@ -59,7 +59,7 @@
     end
 
     before do
-      create(:patient_team, team:, patient:)
+      create(:patient_location, patient:, location: school)
       school_move.confirm!
     end