Skip to content

Commit 74748aa

Browse files
Approving each deployment is overkill
- Move approval into prepare-deployment stage to only approve once
1 parent e071ede commit 74748aa

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

.github/workflows/deploy-application.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,7 @@ jobs:
4646
prepare-deployment:
4747
name: Prepare deployment
4848
runs-on: ubuntu-latest
49+
environment: ${{ inputs.environment }}
4950
permissions:
5051
id-token: write
5152
steps:
@@ -85,7 +86,6 @@ jobs:
8586
runs-on: ubuntu-latest
8687
needs: prepare-deployment
8788
if: inputs.server_types == 'web' || inputs.server_types == 'all'
88-
environment: ${{ inputs.environment }}
8989
permissions:
9090
id-token: write
9191
steps:
@@ -117,7 +117,6 @@ jobs:
117117
runs-on: ubuntu-latest
118118
needs: prepare-deployment
119119
if: inputs.server_types == 'good-job' || inputs.server_types == 'all'
120-
environment: ${{ inputs.environment }}
121120
permissions:
122121
id-token: write
123122
steps:

0 commit comments

Comments
 (0)