Merge pull request #6545 from NHSDigital/fix-school-move-merge

Migrate all changes with foreign keys

Author: MartinVanIJcken

app/lib/team_merger.rb

@@ -269,15 +269,20 @@ def migrate_team_locations(merged_team)
     Rails.logger.debug "Migrating team locations..."
 
     source_teams.each do |source_team|
-      source_team.team_locations.find_each do |tl|
-        if TeamLocation.exists?(
-             team_id: merged_team.id,
-             academic_year: tl.academic_year,
-             location_id: tl.location_id
-           )
-          tl.destroy!
+      source_team.team_locations.find_each do |source_tl|
+        previously_migrated_tl =
+          TeamLocation.find_by(
+            team_id: merged_team.id,
+            academic_year: source_tl.academic_year,
+            location_id: source_tl.location_id
+          )
+        if previously_migrated_tl.present?
+          ConsentForm.where(team_location_id: source_tl.id).update_all(
+            team_location_id: previously_migrated_tl.id
+          )
+          source_tl.destroy!
         else
-          tl.update_columns(team_id: merged_team.id)
+          source_tl.update_columns(team_id: merged_team.id)
         end
       end
     end
@@ -341,39 +346,42 @@ def migrate_generic_locations(merged_team)
         source_ids = pairs.map(&:first)
         merged_loc = pairs.first.last
 
-        VaccinationRecord.where(location_id: source_ids).update_all(
-          location_id: merged_loc.id
-        )
+        [
+          AttendanceRecord,
+          GillickAssessment,
+          PreScreening,
+          VaccinationRecord
+        ].each do |model|
+          model.where(location_id: source_ids).update_all(
+            location_id: merged_loc.id
+          )
+        end
 
-        SchoolMove.where(school_id: source_ids).update_all(
-          school_id: merged_loc.id
-        )
+        [
+          ConsentForm,
+          Patient,
+          PatientChangeset,
+          SchoolMove,
+          SchoolMoveLogEntry
+        ].each do |model|
+          model.where(school_id: source_ids).update_all(
+            school_id: merged_loc.id
+          )
+        end
 
-        keep_ids =
+        patient_location_ids_to_keep =
           PatientLocation
             .where(location_id: source_ids)
             .group(:patient_id, :academic_year)
             .minimum(:id)
             .values
         PatientLocation
           .where(location_id: source_ids)
-          .where.not(id: keep_ids)
+          .where.not(id: patient_location_ids_to_keep)
           .delete_all
-        PatientLocation.where(id: keep_ids).update_all(
+        PatientLocation.where(id: patient_location_ids_to_keep).update_all(
           location_id: merged_loc.id
         )
-
-        [AttendanceRecord, GillickAssessment, PreScreening].each do |model|
-          model.where(location_id: source_ids).update_all(
-            location_id: merged_loc.id
-          )
-        end
-        ConsentForm.where(school_id: source_ids).update_all(
-          school_id: merged_loc.id
-        )
-        Patient.where(school_id: source_ids).update_all(
-          school_id: merged_loc.id
-        )
       end
 
     source_gl_tls.delete_all
@@ -386,8 +394,7 @@ def migrate_generic_locations(merged_team)
   end
 
   def refresh_materialized_views
-    ReportingAPI::Total.refresh!(concurrently: false)
-    ReportingAPI::PatientProgrammeStatus.refresh!(concurrently: false)
+    ReportingAPI::RefreshJob.perform_later
   rescue StandardError => e
     Rails.logger.warn "TeamMerge: could not refresh materialized views: #{e.message}"
   end