Merge pull request #4731 from nhsuk/sms-team-only

Set `delivery_status` from team API key error

Author: thomasleese

app/jobs/sms_delivery_job.rb

@@ -54,6 +54,7 @@ def perform(
                e.message.include?(TEAM_ONLY_API_KEY_MESSAGE)
             # Prevent retries and job failures.
             Sentry.capture_exception(e)
+            [nil, "technical_failure"]
           elsif e.message == INVALID_UK_MOBILE_NUMBER_ERROR
             [nil, "not_uk_mobile_number_failure"]
           else

spec/jobs/sms_delivery_job_spec.rb

@@ -127,6 +127,36 @@
       end
     end
 
+    context "when the parent phone number is not part of the allow list" do
+      before do
+        allow(notifications_client).to receive(:send_sms).and_raise(
+          Notifications::Client::BadRequestError.new(
+            OpenStruct.new(
+              code: 400,
+              body: "Can’t send to this recipient using a team-only API key"
+            )
+          )
+        )
+      end
+
+      it "creates a log entry for the failure" do
+        expect { perform_now }.to change(NotifyLogEntry, :count).by(1)
+
+        notify_log_entry = NotifyLogEntry.last
+        expect(notify_log_entry).to be_sms
+        expect(notify_log_entry).to be_technical_failure
+        expect(notify_log_entry.delivery_id).to be_nil
+        expect(notify_log_entry.recipient).to eq("01234 567890")
+        expect(notify_log_entry.template_id).to eq(
+          GOVUK_NOTIFY_SMS_TEMPLATES[template_name]
+        )
+        expect(notify_log_entry.parent).to eq(parent)
+        expect(notify_log_entry.patient).to eq(patient)
+        expect(notify_log_entry.programme_ids).to eq(programmes.map(&:id))
+        expect(notify_log_entry.sent_by).to eq(sent_by)
+      end
+    end
+
     context "with a consent form" do
       let(:consent_form) do
         create(:consent_form, session:, parent_phone: "01234567890")