Skip to content

Commit 529f3a4

Browse files
committed
Make disease_types not nullable
This value is always set when recording a vaccination record so we can make the column `NOT NULL`. Jira-Issue: MAV-2858
1 parent a0ed5a6 commit 529f3a4

5 files changed

Lines changed: 11 additions & 4 deletions

File tree

app/models/vaccination_record.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# delivery_method :integer
1010
# delivery_site :integer
1111
# discarded_at :datetime
12-
# disease_types :enum is an Array
12+
# disease_types :enum not null, is an Array
1313
# dose_sequence :integer
1414
# full_dose :boolean
1515
# local_patient_id_uri :string
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
# frozen_string_literal: true
2+
3+
class MakeVaccinationRecordDiseaseTypesNotNull < ActiveRecord::Migration[8.1]
4+
def change
5+
change_column_null :vaccination_records, :disease_types, false
6+
end
7+
end

db/schema.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -935,7 +935,7 @@
935935
t.integer "delivery_method"
936936
t.integer "delivery_site"
937937
t.datetime "discarded_at"
938-
t.enum "disease_types", array: true, enum_type: "disease_type"
938+
t.enum "disease_types", null: false, array: true, enum_type: "disease_type"
939939
t.integer "dose_sequence"
940940
t.boolean "full_dose"
941941
t.string "local_patient_id"

spec/factories/vaccination_records.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# delivery_method :integer
1010
# delivery_site :integer
1111
# discarded_at :datetime
12-
# disease_types :enum is an Array
12+
# disease_types :enum not null, is an Array
1313
# dose_sequence :integer
1414
# full_dose :boolean
1515
# local_patient_id_uri :string

spec/models/vaccination_record_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
# delivery_method :integer
1010
# delivery_site :integer
1111
# discarded_at :datetime
12-
# disease_types :enum is an Array
12+
# disease_types :enum not null, is an Array
1313
# dose_sequence :integer
1414
# full_dose :boolean
1515
# local_patient_id_uri :string

0 commit comments

Comments
 (0)