Merge pull request #6669 from NHSDigital/remove-capybara-javascript-driver

Remove unused Cuprite-related code

Author: floehopper

Gemfile

@@ -118,9 +118,7 @@ group :test do
   gem "capybara"
   gem "capybara_accessible_selectors",
       github: "citizensadvice/capybara_accessible_selectors"
-  gem "capybara-screenshot"
   gem "climate_control"
-  gem "cuprite"
   gem "database_cleaner-active_record"
   gem "its"
   gem "rack_session_access"

Gemfile.lock

@@ -237,18 +237,13 @@ GEM
       rack-test (>= 0.6.3)
       regexp_parser (>= 1.5, < 3.0)
       xpath (~> 3.2)
-    capybara-screenshot (1.0.27)
-      capybara (>= 1.0, < 4)
-      launchy
     caxlsx (4.4.2)
       htmlentities (~> 4.3, >= 4.3.4)
       marcel (~> 1.0)
       nokogiri (~> 1.10, >= 1.10.4)
       rubyzip (>= 2.4, < 4)
     cgi (0.5.1)
     charlock_holmes (0.7.9)
-    childprocess (5.1.0)
-      logger (~> 1.5)
     climate_control (1.2.0)
     coderay (1.1.3)
     concurrent-ruby (1.3.6)
@@ -271,9 +266,6 @@ GEM
     cssbundling-rails (1.4.3)
       railties (>= 6.0.0)
     csv (3.3.5)
-    cuprite (0.17)
-      capybara (~> 3.0)
-      ferrum (~> 0.17.0)
     data_migrate (11.3.1)
       activerecord (>= 6.1)
       railties (>= 6.1)
@@ -346,12 +338,6 @@ GEM
       faraday (>= 1, < 3)
     faraday-net_http (3.4.2)
       net-http (~> 0.5)
-    ferrum (0.17.1)
-      addressable (~> 2.5)
-      base64 (~> 0.2)
-      concurrent-ruby (~> 1.1)
-      webrick (~> 1.7)
-      websocket-driver (~> 0.7)
     ffi (1.17.3-arm64-darwin)
     ffi (1.17.3-x86_64-linux-gnu)
     fhir_models (5.0.0)
@@ -446,10 +432,6 @@ GEM
     kramdown-parser-gfm (1.1.0)
       kramdown (~> 2.0)
     language_server-protocol (3.17.0.5)
-    launchy (3.1.1)
-      addressable (~> 2.8)
-      childprocess (~> 5.0)
-      logger (~> 1.6)
     lint_roller (1.1.0)
     listen (3.9.0)
       rb-fsevent (~> 0.10, >= 0.10.3)
@@ -945,15 +927,13 @@ DEPENDENCIES
   bootsnap
   brakeman
   capybara
-  capybara-screenshot
   capybara_accessible_selectors!
   caxlsx
   charlock_holmes
   climate_control
   config
   cssbundling-rails
   csv
-  cuprite
   data_migrate
   database_cleaner-active_record
   debug

spec/spec_helper.rb

@@ -108,26 +108,11 @@
 end
 require "rspec/rails"
 # Add additional requires below this line. Rails is not loaded until this point!
-require "capybara/cuprite"
-require "capybara-screenshot/rspec"
 require "rack_session_access/capybara"
 require "console"
 
 Faker::Config.locale = "en-GB"
 
-Capybara.register_driver(:cuprite_custom) do |app|
-  Capybara::Cuprite::Driver.new(
-    app,
-    inspector: ENV["DEBUG_TESTS"],
-    js_errors: true,
-    window_size: [1200, 800],
-    process_timeout: 30
-  )
-end
-
-Capybara.asset_host = "http://localhost:4000"
-Capybara.javascript_driver = :cuprite_custom
-
 Console.logger.off!
 Capybara.server = :falcon
 
@@ -186,14 +171,6 @@
 
   config.filter_run_excluding :local_users
 
-  if ENV["CI"].blank?
-    begin
-      Ferrum::Browser.new
-    rescue Ferrum::BinaryNotFoundError
-      config.filter_run_excluding :js
-    end
-  end
-
   config.infer_spec_type_from_file_location!
 
   config.define_derived_metadata(file_path: %r{/spec/components/}) do |metadata|