Merge pull request #5750 from nhsuk/mike/hide-activity-log-for-national-reporting

Hide patient activity log for national reporting teams

Author: mikejamesthompson

app/components/app_activity_log_component.rb

@@ -18,11 +18,7 @@ def initialize(team:, patient:, session: nil)
     @patient = patient
 
     @archive_reasons =
-      if team.has_upload_only_access?
-        []
-      else
-        @patient.archive_reasons.where(team:).includes(:created_by)
-      end
+      @patient.archive_reasons.where(team:).includes(:created_by)
 
     @attendance_records =
       patient

app/policies/patient_policy.rb

@@ -7,7 +7,7 @@ def show? = true
 
   def update? = true
 
-  def log? = show?
+  def log? = team.has_poc_only_access?
 
   def pds_search_history? = show?
 

app/views/patients/show.html.erb

@@ -7,10 +7,12 @@
 
 <%= render "patients/header" %>
 
-<%= render AppSecondaryNavigationComponent.new do |nav|
-      nav.with_item(href: patient_path(@patient), text: "Child record", selected: true)
-      nav.with_item(href: log_patient_path(@patient), text: "Activity log")
-    end %>
+<% if policy(@patient).log? %>
+  <%= render AppSecondaryNavigationComponent.new do |nav|
+        nav.with_item(href: patient_path(@patient), text: "Child record", selected: true)
+        nav.with_item(href: log_patient_path(@patient), text: "Activity log")
+      end %>
+<% end %>
 
 <% vaccinations_card = capture do %>
   <%= render AppCardComponent.new(section: true) do |card| %>

spec/components/app_activity_log_component_spec.rb

@@ -86,14 +86,6 @@
                      notes: "Extra details",
                      date: "1 June 2024 at 12:00pm",
                      by: "JOY, Nurse"
-
-    context "when viewing as an upload only team" do
-      let(:team) { create(:team, type: :upload_only, programmes:) }
-
-      it "does not render archive events" do
-        expect(rendered).not_to have_content("Record archived")
-      end
-    end
   end
 
   describe "consent given by parents" do

spec/features/upload_only_team_spec.rb

@@ -29,6 +29,7 @@
     when_i_visit_the_children_page
     and_i_find_a_child(given_name: "Harry", family_name: "Potter")
     then_i_should_see_vaccinations_then_child_details
+    and_the_activity_log_is_hidden
     and_child_cannot_be_archived
     and_child_does_not_look_archived
   end
@@ -200,4 +201,9 @@ def then_i_should_not_see_parent_details
   def and_i_should_not_see_add_parent_button
     expect(page).not_to have_content("Add parent or guardian")
   end
+
+  def and_the_activity_log_is_hidden
+    expect(page).not_to have_content("Activity log")
+    expect(page).not_to have_content("Child record")
+  end
 end