Move already had notification sending to after commit

`ImmunisationImport` was triggering the `AlreadyHadNotificationSender`
within the transaction that wraps the import process. This could
theoretically lead to issues with the email job getting queued in
Sidekiq before the data has been committed to the database. This
is a possible reason for some of the missing emails that have been
reported in prod and test.

Jira-Issue: MAV-3418

Author: stevehook

app/models/immunisation_import.rb

@@ -217,15 +217,15 @@ def postprocess_rows!
 
     PatientTeamUpdater.call(patient_scope: patients)
     PatientStatusUpdater.call(patient_scope: Patient.where(id: patients.ids))
+  end
+
+  def post_commit!
+    vaccination_records.sync_all_to_nhs_immunisations_api
 
     vaccination_records
       .includes(:patient, :team, :subteam)
       .find_each do |vaccination_record|
         AlreadyHadNotificationSender.call(vaccination_record:)
       end
   end
-
-  def post_commit!
-    vaccination_records.sync_all_to_nhs_immunisations_api
-  end
 end

spec/models/immunisation_import_spec.rb

@@ -539,6 +539,14 @@
         SyncVaccinationRecordToNHSJob
       ).with(vaccination_record.id).once.on("immunisations_api_sync")
     end
+
+    it "calls the AlreadyHadNotificationSender for the vaccination record" do
+      expect(AlreadyHadNotificationSender).to receive(:call).with(
+        vaccination_record:
+      )
+
+      immunisation_import.send :post_commit!
+    end
   end
 
   describe "#postprocess_rows!" do
@@ -576,13 +584,5 @@
         ).by(1)
       end
     end
-
-    it "calls the AlreadyHadNotificationSender for the vaccination record" do
-      expect(AlreadyHadNotificationSender).to receive(:call).with(
-        vaccination_record:
-      )
-
-      immunisation_import.send :postprocess_rows!
-    end
   end
 end