Don't attach teams or performed by to next dose triages

This allows the delay vaccination triages to be created from historical
uploads and not just vaccination records that were recorded in the
service.

Jira-Issue: MAV-2991

Author: thomasleese

app/lib/next_dose_triage_factory.rb

@@ -8,10 +8,6 @@ def initialize(vaccination_record:)
   def call
     return unless should_create?
 
-    # This factory should only be called for vaccination records performed in
-    #  the service, meaning there should always be a `performed_by` set.
-    raise UnknownPerformedBy if performed_by_user_id.nil?
-
     ActiveRecord::Base.transaction do
       Triage
         .create!(attributes:)
@@ -29,13 +25,12 @@ def self.call(...) = new(...).call
 
   attr_reader :vaccination_record
 
-  delegate :academic_year, :patient, :programme, :team, to: :vaccination_record
+  delegate :academic_year, :patient, :programme, to: :vaccination_record
 
   def should_create?
-    unless vaccination_record.sourced_from_service? &&
-             vaccination_record.administered? && programme.mmr?
-      return false
-    end
+    return false unless vaccination_record.administered? && programme.mmr?
+
+    return false if next_date.past?
 
     dose_sequence =
       patient.vaccination_status(programme:, academic_year:).dose_sequence
@@ -45,21 +40,14 @@ def should_create?
 
   def next_date = vaccination_record.performed_at + 28.days
 
-  def performed_by_user_id = vaccination_record.performed_by_user_id
-
   def attributes
     {
       patient:,
-      team:,
       programme:,
-      performed_by_user_id:,
       status: "delay_vaccination",
       academic_year:,
       notes: "Next dose #{next_date.to_fs(:long)}",
       delay_vaccination_until: next_date
     }
   end
-
-  class UnknownPerformedBy < StandardError
-  end
 end

spec/lib/next_dose_triage_factory_spec.rb

@@ -3,9 +3,7 @@
 describe NextDoseTriageFactory do
   subject(:call) { described_class.call(vaccination_record:) }
 
-  let(:vaccination_record) { create(:vaccination_record, session:, programme:) }
-
-  let(:session) { create(:session, programmes: [programme]) }
+  let(:vaccination_record) { create(:vaccination_record, programme:) }
 
   context "with a single dose programme" do
     let(:programme) { Programme.hpv }
@@ -24,31 +22,17 @@
       triage = vaccination_record.reload.next_dose_delay_triage
       expect(triage).to be_delay_vaccination
       expect(triage.delay_vaccination_until).to eq(28.days.from_now.to_date)
-      expect(triage.performed_by).to eq(vaccination_record.performed_by_user)
+      expect(triage.performed_by).to be_nil
+      expect(triage.team).to be_nil
     end
 
-    context "when not recorded in the service" do
-      let(:session) { nil }
-
-      it "does not create a triage" do
-        expect { call }.not_to(change(Triage, :count))
-      end
-    end
-
-    context "when the vaccination record is missing a performed by user" do
+    context "when performed over 28 days ago" do
       let(:vaccination_record) do
-        create(
-          :vaccination_record,
-          session:,
-          programme:,
-          performed_by_user: nil
-        )
+        create(:vaccination_record, programme:, performed_at: 29.days.ago)
       end
 
-      it "raises an error" do
-        expect { call }.to raise_error(
-          NextDoseTriageFactory::UnknownPerformedBy
-        )
+      it "does not create a triage" do
+        expect { call }.not_to(change(Triage, :count))
       end
     end
   end