Fix: ignore dismissed notices when generating new important notices

`ImportantNoticeGeneratorJob` builds an in-memory index of "existing notices" and
uses it to decide whether to create missing notices for a patient. Previously
that index included dismissed notices, so a dismissed notice was treated as
"already exists". This meant notices could fail to reappear when a patient status
was cleared and later re-applied (e.g. restricted -> dismissed when cleared ->
restricted again, but no new active restricted notice created).

Change:
- Build existing notices from active notices only by filtering on `dismissed_at: nil`
- Simplify dismissal selection logic since existing notices is now active-only

Author: jhenderson

app/jobs/important_notice_generator_job.rb

@@ -31,7 +31,7 @@ def process_batch(patients)
 
     existing_notices =
       ImportantNotice
-        .where(patient_id: patients.map(&:id))
+        .where(patient_id: patients.map(&:id), dismissed_at: nil)
         .index_by { notice_key(it) }
 
     patients.each do |patient|
@@ -104,7 +104,7 @@ def dismiss_existing_notices_based_on_patient_status(
 
       existing_notices.each_value do |notice|
         unless notice.patient_id == patient.id && notice.team_id == team_id &&
-                 notice.type == type.to_s && notice.dismissed_at.nil?
+                 notice.type == type.to_s
           next
         end
 

spec/jobs/important_notice_generator_job_spec.rb

@@ -76,6 +76,37 @@
             }.from(1).to(0)
           end
         end
+
+        context "when a restricted notice was dismissed and the patient becomes restricted again" do
+          before do
+            # Create initial notices
+            patient.update_column(:restricted_at, Time.current)
+            described_class.perform_now([patient.id])
+
+            # Clear restriction and dismiss notices
+            patient.update_column(:restricted_at, nil)
+            described_class.perform_now([patient.id])
+
+            # Re-apply restriction
+            patient.update_column(:restricted_at, Time.current)
+          end
+
+          it "creates a new active restricted notice (dismissed notices do not block re-creation)" do
+            expect { described_class.perform_now([patient.id]) }.to change {
+              ImportantNotice
+                .active(team: team_a)
+                .where(patient:, type: :restricted)
+                .count
+            }.from(0).to(1)
+
+            expect(
+              ImportantNotice
+                .dismissed(team: team_a)
+                .where(patient:, type: :restricted)
+                .count
+            ).to be >= 1
+          end
+        end
       end
 
       context "invalidated" do