Merge pull request #6593 from NHSDigital/simplify-batching-query-in-patient-status-updater

Simplify batching query in PatientStatusUpdater

Author: floehopper

app/lib/patient_status_updater.rb

@@ -42,16 +42,18 @@ def update_programme_statuses!
 
     merge_patient_scope(Patient::ProgrammeStatus)
       .where(academic_year: academic_years)
-      .includes(
-        :attendance_record,
-        :consents,
-        :patient,
-        :patient_locations,
-        :triages,
-        :vaccination_records,
-        :parents
-      )
-      .find_in_batches do |batch|
+      .in_batches do |relation|
+        batch =
+          relation.includes(
+            :attendance_record,
+            :consents,
+            :patient,
+            :patient_locations,
+            :triages,
+            :vaccination_records,
+            :parents
+          ).to_a
+
         batch.each(&:assign)
 
         Patient::ProgrammeStatus.import!(