Skip to content

Commit 29eefe2

Browse files
authored
Merge pull request #6279 from NHSDigital/pr-merge-e2e-tests-secrets
Fix CD workflow
2 parents ab131fb + 2416cf0 commit 29eefe2

2 files changed

Lines changed: 12 additions & 3 deletions

File tree

.github/workflows/call-end-to-end-tests.yml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,13 @@ on:
1212
github_ref:
1313
required: true
1414
type: string
15+
secrets:
16+
HTTP_AUTH_TOKEN_FOR_TESTS:
17+
description: HTTP Basic Auth token for the environment under test
18+
required: false
19+
MAVIS_TESTING_REPO_ACCESS_TOKEN:
20+
description: Access token for the manage-vaccinations-in-schools-testing repository
21+
required: false
1522

1623
jobs:
1724
call-tests:

.github/workflows/continuous-deployment.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,8 @@ jobs:
2525
run_pre_deploy_migrations: false
2626
end-to-end-tests:
2727
needs: [deploy]
28-
if: ${{ contains(needs.deploy.result, 'success') && github.ref_name == 'next' }}
2928
uses: ./.github/workflows/call-end-to-end-tests.yml
29+
secrets: inherit
3030
with:
3131
cross_service_tests: true
3232
endpoint: https://qa.mavistesting.com
@@ -41,8 +41,9 @@ jobs:
4141
if: needs.test.result == 'failure' || needs.deploy.result == 'failure'
4242
uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a
4343
with:
44-
webhook: ${{ secrets.SLACK_MAVIS_ALERTS_WEBHOOK_URL }}
44+
webhook: ${{ secrets.SLACK_MAVIS_TECH_WEBHOOK_URL }}
4545
webhook-type: incoming-webhook
46+
errors: true
4647
# yamllint disable rule:line-length
4748
payload: |
4849
text: ":rotating_light: Continuous Deployment failed :rotating_light:"
@@ -57,8 +58,9 @@ jobs:
5758
if: needs.end-to-end-tests.result == 'failure'
5859
uses: slackapi/slack-github-action@91efab103c0de0a537f72a35f6b8cda0ee76bf0a
5960
with:
60-
webhook: ${{ secrets.SLACK_MAVIS_ALERTS_WEBHOOK_URL }}
61+
webhook: ${{ secrets.SLACK_MAVIS_TECH_WEBHOOK_URL }}
6162
webhook-type: incoming-webhook
63+
errors: true
6264
# yamllint disable rule:line-length
6365
payload: |
6466
text: ":rotating_light: E2E tests failed on next :rotating_light:"

0 commit comments

Comments
 (0)