Set default working directory where possible (#3258)

In the GitHub Actions workflows, this uses the `defaults` option to set
the working directory to the `terraform/app` directory by default so we
don't need to override it for each step in the workflow.

See

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/setting-a-default-shell-and-working-directory
for more information on how this works.

Author: thomasleese

.github/workflows/deploy-application.yml

@@ -30,7 +30,7 @@ env:
   aws-role: ${{ inputs.environment == 'production'
     && 'arn:aws:iam::820242920762:role/GithubDeployMavisAndInfrastructure'
     || 'arn:aws:iam::393416225559:role/GithubDeployMavisAndInfrastructure' }}
-  tf-dir: terraform/app
+  terraform-working-directory: terraform/app
 
 jobs:
   plan-changes:
@@ -65,7 +65,7 @@ jobs:
           terraform_version: 1.10.5
       - name: Update the task definition
         id: plan
-        working-directory: ${{ env.tf-dir }}
+        working-directory: ${{ env.terraform-working-directory }}
         run: |
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl" -upgrade
           terraform plan -var="image_digest=$DIGEST" -target=aws_ecs_task_definition.task_definition \
@@ -105,7 +105,7 @@ jobs:
         with:
           terraform_version: 1.10.5
       - name: Apply the changes
-        working-directory: ${{ env.tf-dir }}
+        working-directory: ${{ env.terraform-working-directory }}
         run: |
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl" -upgrade
           terraform apply ${{ runner.temp }}/tfplan

.github/workflows/deploy-infrastructure.yml

@@ -31,7 +31,10 @@ env:
   aws_role: ${{ inputs.environment == 'production'
     && 'arn:aws:iam::820242920762:role/GithubDeployMavisAndInfrastructure'
     || 'arn:aws:iam::393416225559:role/GithubDeployMavisAndInfrastructure' }}
-  tf_dir: terraform/app
+
+defaults:
+  run:
+    working-directory: terraform/app
 
 jobs:
   plan:
@@ -54,11 +57,8 @@ jobs:
       - name: Install AWS Cli
         run: sudo snap install --classic aws-cli
       - name: Check if any deployments are running
-        working-directory: ${{ env.tf_dir }}
-        run: |
-          ../scripts/check-for-running-deployments.sh ${{ inputs.environment }}
+        run: ../scripts/check-for-running-deployments.sh ${{ inputs.environment }}
       - name: Get image digest
-        working-directory: ${{ env.tf_dir }}
         run: |
           DIGEST="${{ inputs.docker_sha }}"
           if terraform state list | grep -q 'aws_ecs_task_definition.task_definition'; then
@@ -72,15 +72,14 @@ jobs:
           echo "DIGEST=$DIGEST" >> $GITHUB_ENV
       - name: Terraform Plan
         id: plan
-        working-directory: ${{ env.tf_dir }}
         run: |
           set -e
           terraform plan -var="image_digest=$DIGEST" -var-file="env/${{ inputs.environment }}.tfvars" \
           -out ${{ runner.temp }}/tfplan | tee ${{ runner.temp }}/tf_stdout
       - name: Validate the changes
         run: |
           set -e
-          ./terraform/scripts/validate_plan.sh ${{ runner.temp }}/tf_stdout
+          ../scripts/validate_plan.sh ${{ runner.temp }}/tf_stdout
       - name: Upload artifact
         uses: actions/upload-artifact@v4
         with:
@@ -112,7 +111,6 @@ jobs:
         with:
           terraform_version: 1.10.5
       - name: Apply the changes
-        working-directory: ${{ env.tf_dir }}
         run: |
           set -e
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl" -upgrade

…hub/workflows/destroy_infrastructure.yml …hub/workflows/destroy-infrastructure.yml.github/workflows/destroy_infrastructure.yml renamed to .github/workflows/destroy-infrastructure.yml .github/workflows/destroy_infrastructure.yml renamed to .github/workflows/destroy-infrastructure.yml

@@ -1,5 +1,5 @@
-name: Destroy Infrastructure
-run-name: Destroy Infrastructure for ${{ inputs.environment }}
+name: Destroy infrastructure
+run-name: Destroy infrastructure for ${{ inputs.environment }}
 
 on:
   workflow_dispatch:
@@ -18,14 +18,17 @@ on:
 
 env:
   aws_role: arn:aws:iam::393416225559:role/GithubDeployMavisAndInfrastructure
-  tf_dir: terraform/app
 
 jobs:
   destroy-resources:
+    name: Destroy resources
     runs-on: ubuntu-latest
     permissions:
       id-token: write
     environment: ${{ inputs.environment }}
+    defaults:
+      run:
+        working-directory: terraform/app
     steps:
       - name: Checkout code
         uses: actions/checkout@v4
@@ -39,7 +42,6 @@ jobs:
         with:
           terraform_version: 1.10.5
       - name: Ensure DB cluster can be deleted
-        working-directory: ${{ env.tf_dir }}
         run: |
           set -e
           terraform init -backend-config="env/${{ inputs.environment }}-backend.hcl" -upgrade
@@ -53,11 +55,12 @@ jobs:
           fi
 
       - name: Delete cluster
-        working-directory: ${{ env.tf_dir }}
         run: |
           terraform destroy -var-file="env/${{ inputs.environment }}.tfvars" \
           -var="image_digest=notneededfordestroy" -auto-approve
+
   destroy-backend:
+    name: Destroy backend
     runs-on: ubuntu-latest
     needs: destroy-resources
     permissions: