Remove requirement for clinic to have a team

This helps to keep the clinic model similar to the school model,
allowing for two separate CLI tools: one which creates clinics and
another which adds them to organisations.

Author: thomasleese

app/models/location.rb

@@ -64,16 +64,13 @@ class Location < ApplicationRecord
   validates :url, url: true, allow_nil: true
   validates :urn, uniqueness: true, allow_nil: true
 
-  with_options if: :clinic? do
-    validates :team, presence: true
-  end
-
   with_options if: :community_clinic? do
     validates :ods_code, exclusion: { in: :organisation_ods_code }
   end
 
   with_options if: :generic_clinic? do
     validates :ods_code, inclusion: { in: :organisation_ods_code }
+    validates :team, presence: true
   end
 
   with_options if: :gp_practice? do
@@ -121,9 +118,9 @@ def create_default_programme_year_groups!(programmes)
 
   private
 
-  def organisation_ods_code
-    [team&.organisation&.ods_code]
-  end
+  def organisation_ods_code = [team&.organisation&.ods_code].compact
 
-  def fhir_mapper = @fhir_mapper ||= FHIRMapper::Location.new(self)
+  def fhir_mapper
+    @fhir_mapper ||= FHIRMapper::Location.new(self)
+  end
 end

spec/factories/locations.rb

@@ -65,8 +65,6 @@
       name { "#{Faker::University.name} Clinic" }
 
       sequence(:ods_code, 100) { "CL#{_1}" }
-
-      organisation
     end
 
     factory :generic_clinic do

spec/models/location_spec.rb

@@ -175,7 +175,7 @@
           "gias_establishment_number" => nil,
           "gias_local_authority_code" => nil,
           "id" => location.id,
-          "is_attached_to_organisation" => true,
+          "is_attached_to_organisation" => false,
           "name" => location.name,
           "ods_code" => location.ods_code,
           "status" => "unknown",