Merge pull request #6014 from nhsuk/alistair/fix-check-imms-api-sync-feature-flag

Check `imms_api_sync_job` feature flag actors correctly

Author: alistair-white-horne-tng

app/components/app_vaccination_record_summary_component.rb

@@ -306,11 +306,12 @@ def call
       end
 
       correct_feature_flags_enabled =
-        Programme.all.any? { Flipper.enabled?(:imms_api_sync_job, it) } &&
-          Flipper.enabled?(:imms_api_integration)
+        Programme.all_as_variants.any? do
+          Flipper.enabled?(:imms_api_sync_job, it)
+        end && Flipper.enabled?(:imms_api_integration)
       if @vaccination_record.respond_to?(:sync_status) &&
            correct_feature_flags_enabled &&
-           @vaccination_record&.correct_source_for_nhs_immunisations_api?
+           @vaccination_record.correct_source_for_nhs_immunisations_api?
         summary_list.with_row do |row|
           row.with_key { "Synced with NHS England?" }
           row.with_value do
@@ -339,9 +340,11 @@ def source_value
   end
 
   def outcome_value
-    outcome = VaccinationRecord.human_enum_name(:outcome, @vaccination_record.outcome)
+    outcome =
+      VaccinationRecord.human_enum_name(:outcome, @vaccination_record.outcome)
 
-    if @vaccination_record.already_had? && @vaccination_record.reported_as_already_vaccinated?
+    if @vaccination_record.already_had? &&
+         @vaccination_record.reported_as_already_vaccinated?
       outcome = VaccinationRecord.human_enum_name(:outcome, "administered")
     end
 

app/models/concerns/syncable_to_nhs_immunisations_api.rb

@@ -18,7 +18,9 @@ module SyncableToNHSImmunisationsAPI
     scope :sync_all_to_nhs_immunisations_api,
           -> do
             programmes =
-              Programme.all.select { Flipper.enabled?(:imms_api_sync_job, it) }
+              Programme.all_as_variants.select do
+                Flipper.enabled?(:imms_api_sync_job, it)
+              end
 
             ids =
               with_correct_source_for_nhs_immunisations_api.for_programmes(