Skip to content

Commit 1501d67

Browse files
authored
Merge pull request #6174 from NHSDigital/contributing
Add some contributing text about code reviews
2 parents abdda67 + 12cfddf commit 1501d67

1 file changed

Lines changed: 11 additions & 0 deletions

File tree

CONTRIBUTING.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
# Contributing
2+
3+
## Code reviews
4+
5+
All pull requests should be reviewed by another developer on the team before
6+
they can be merged in.
7+
8+
Don't be afraid to use "Request changes" when suggesting changes to a pull
9+
request. This helps to make it easier to filter in lists of pull requests
10+
which are still in need of a review, and the person who raised the pull
11+
request can still dismiss the review if they disagree.

0 commit comments

Comments
 (0)