Only report LocationPositionUpdater::NoResults in production

In our non-production environments we often have locations that are
generated from fake data which means they're almost certainly going to
fail. These aren't actionable errors so there's no need to send them to
Sentry.

Jira-Issue: MAV-6707
Jira-Issue: MAV-6379

Author: thomasleese

app/jobs/location_position_updater_job.rb

@@ -9,6 +9,13 @@ def perform(location_id)
     location = Location.find(location_id)
     LocationPositionUpdater.call(location)
   rescue LocationPositionUpdater::NoResults => e
-    Sentry.capture_exception(e, level: "warning")
+    if Settings.location_position_updater_job.capture_exception
+      Sentry.capture_exception(e, level: "warning")
+    else
+      Rails.logger.warn(
+        "Could not fetch position for: #{location.name} (#{location.id})"
+      )
+      Rails.logger.warn(e.backtrace.join("\n"))
+    end
   end
 end

config/settings.yml

@@ -64,6 +64,9 @@ ordnance_survey:
   api_key: <%= Rails.application.credentials.ordnance_survey&.api_key %>
   secret_key: <%= Rails.application.credentials.ordnance_survey&.secret_key %>
 
+location_position_updater_job:
+  capture_exception: true
+
 # Set a value to override the default values set in config/initializers/devise.rb
 devise:
   timeout_in_seconds:

config/settings/development.yml

@@ -29,3 +29,6 @@ reporting_api:
 
 careplus:
   base_url: http://localhost:8080
+
+location_position_updater_job:
+  capture_exception: false

config/settings/end_to_end.yml

@@ -26,3 +26,6 @@ splunk:
 reporting_api:
   client_app:
     root_url: http://localhost:4101
+
+location_position_updater_job:
+  capture_exception: false

config/settings/staging.yml

@@ -20,3 +20,6 @@ pds:
 
 careplus:
   base_url: <%= ENV.fetch("MOCK_CAREPLUS_URL", nil) %>
+
+location_position_updater_job:
+  capture_exception: false

config/settings/test.yml

@@ -27,3 +27,6 @@ reporting_api:
 
 careplus:
   base_url: http://localhost:8080
+
+location_position_updater_job:
+  capture_exception: false

spec/jobs/location_position_updater_job_spec.rb

@@ -39,16 +39,35 @@
         allow(LocationPositionUpdater).to receive(:call).and_raise(error)
       end
 
-      it "captures the exception in Sentry at warning level" do
-        expect(Sentry).to receive(:capture_exception).with(
-          error,
-          level: "warning"
-        )
-        perform
+      context "when not capturing the exception" do
+        it "doesn't capture the exception in Sentry" do
+          expect(Sentry).not_to receive(:capture_exception)
+          perform
+        end
+
+        it "does not raise the error" do
+          expect { perform }.not_to raise_error
+        end
       end
 
-      it "does not raise the error" do
-        expect { perform }.not_to raise_error
+      context "when capturing the exception" do
+        before do
+          Settings.location_position_updater_job.capture_exception = true
+        end
+
+        after { Settings.reload! }
+
+        it "captures the exception in Sentry at warning level" do
+          expect(Sentry).to receive(:capture_exception).with(
+            error,
+            level: "warning"
+          )
+          perform
+        end
+
+        it "does not raise the error" do
+          expect { perform }.not_to raise_error
+        end
       end
     end