Merge pull request #5825 from nhsuk/external-missing-practitioner-mav-3104

Handle external or missing practitioner user

Author: misaka

app/lib/fhir_mapper/vaccination_record.rb

@@ -18,10 +18,10 @@ def initialize(vaccination_record)
     def fhir_record
       immunisation = FHIR::Immunization.new(id: nhs_immunisations_api_id)
 
-      if performed_by_user.present?
-        immunisation.contained << performed_by_user.fhir_practitioner(
-          reference_id: "Practitioner1"
-        )
+      if performed_by.present?
+        immunisation.contained << FHIRMapper::User.new(
+          performed_by
+        ).fhir_practitioner(reference_id: "Practitioner1")
       end
 
       immunisation.contained << patient.fhir_record(reference_id: "Patient1")
@@ -44,10 +44,12 @@ def fhir_record
       immunisation.site = fhir_site
       immunisation.route = fhir_route
       immunisation.doseQuantity = fhir_dose_quantity
-      immunisation.performer = [
-        fhir_user_performer(reference_id: "Practitioner1"),
-        fhir_org_performer
-      ]
+      if performed_by.present?
+        immunisation.performer << fhir_user_performer(
+          reference_id: "Practitioner1"
+        )
+      end
+      immunisation.performer << fhir_org_performer
       immunisation.reasonCode = [fhir_reason_code]
       immunisation.protocolApplied = [fhir_protocol_applied]
 

spec/lib/fhir_mapper/vaccination_record_spec.rb

@@ -62,9 +62,32 @@
     end
 
     describe "contained performing practitioner" do
-      subject { immunisation_fhir.contained.find { it.id == "Practitioner1" } }
+      subject(:contained_practitioner) do
+        immunisation_fhir.contained.find { it.id == "Practitioner1" }
+      end
 
       it { should eq user.fhir_practitioner(reference_id: "Practitioner1") }
+
+      context "when the performing professional is not a local user" do
+        subject(:name) { contained_practitioner.name.first }
+
+        before do
+          vaccination_record.update(
+            performed_by_user: nil,
+            performed_by_given_name: "John",
+            performed_by_family_name: "Howie"
+          )
+        end
+
+        its(:given) { should eq ["John"] }
+        its(:family) { should eq "Howie" }
+      end
+
+      context "when the performing professional is missing" do
+        before { vaccination_record.update(performed_by_user: nil) }
+
+        it { should be_nil }
+      end
     end
 
     describe "performing practitioner" do