Merge pull request #5979 from nhsuk/alistair/national-reporting-upload-numbers

Show better stats to national reporting uploads

Author: alistair-white-horne-tng

app/components/app_import_statistics_component.rb

@@ -0,0 +1,16 @@
+# frozen_string_literal: true
+
+class AppImportStatisticsComponent < ViewComponent::Base
+  erb_template <<-ERB
+    <p><strong>Out of <%= pluralize(@import.rows_count, "record") %> found in the file:</strong></p>
+    <ul>
+      <li><%= pluralize(@import.new_record_count, "new record") %> imported</li>
+      <li><%= pluralize(@import.exact_duplicate_record_count, "duplicate") %> not imported</li>
+      <li><%= pluralize(@import.ignored_record_count, "'not vaccinated' record") %> not imported</li>
+    </ul>
+  ERB
+
+  def initialize(import:)
+    @import = import
+  end
+end

app/components/app_import_summary_component.html.erb

@@ -49,10 +49,17 @@
     <% end %>
 
     <% if import.records_count && import.records_count.positive? %>
+      <% if import.is_a?(ImmunisationImport) && import.type == "national_reporting" %>
         <%= summary_list.with_row do |row| %>
-            <%= row.with_key { "Records" } %>
-            <%= row.with_value { import.records_count.to_s } %>
+          <%= row.with_key { "Import summary" } %>
+          <%= row.with_value { render AppImportStatisticsComponent.new(import: import) } %>
         <% end %>
+      <% else %>
+        <%= summary_list.with_row do |row| %>
+          <%= row.with_key { "Records" } %>
+          <%= row.with_value { import.records_count.to_s } %>
+        <% end %>
+      <% end %>
     <% end %>
   <% end %>
 

spec/features/import_vaccination_records_national_reporting_spec.rb

@@ -27,6 +27,7 @@
     when_i_go_back_to_the_upload_page
     and_i_upload_a_valid_mixed_file
     then_i_should_see_the_upload
+    and_i_should_see_some_stats_about_the_import
     and_i_should_see_the_vaccination_records
     and_the_patients_should_now_be_associated_with_the_team
     and_the_newly_created_patients_should_be_archived
@@ -183,6 +184,13 @@ def then_i_should_see_the_upload
     expect(page).to have_content("Uploaded byUSER, Test")
   end
 
+  def and_i_should_see_some_stats_about_the_import
+    expect(page).to have_content("Out of 3 records found in the file:")
+    expect(page).to have_content("2 new records imported")
+    expect(page).to have_content("0 duplicates not imported")
+    expect(page).to have_content("1 'not vaccinated' record not imported")
+  end
+
   def and_the_patients_should_now_be_associated_with_the_team
     Patient.all.find_each { |patient| expect(patient.teams).to include(@team) }
   end

spec/features/national_reporting_team_spec.rb

@@ -11,7 +11,7 @@
     and_i_should_see_the_national_reporting_service_guide_link
   end
 
-  scenario "Navigation shows only import, children and your team" do
+  scenario "Navigation shows only import and children tabs" do
     given_i_am_signed_in_as_an_national_reporting_team
     when_i_visit_the_dashboard
     then_i_should_see_only_import_and_children_navigation_items