Rename syncable_to_nhs_immunisations_api to ...

with_correct_source_for_nhs_immunisations_api and
correct_source_for_nhs_immunisations_api?

Makes more sense since these methods are only there to check the source of the
vaccination record.

Jira-Issue: MAV-2733

Author: misaka

app/lib/nhs/immunisations_api.rb

@@ -263,7 +263,7 @@ def should_be_in_immunisations_api?(
       ignore_nhs_number: false
     )
       vaccination_record.kept? &&
-        vaccination_record.syncable_to_nhs_immunisations_api? &&
+        vaccination_record.correct_source_for_nhs_immunisations_api? &&
         vaccination_record.administered? &&
         Flipper.enabled?(:imms_api_sync_job, vaccination_record.programme) &&
         (ignore_nhs_number || vaccination_record.patient.nhs_number.present?) &&

app/models/concerns/vaccination_record_sync_to_nhs_immunisations_api_concern.rb

@@ -4,7 +4,7 @@ module VaccinationRecordSyncToNHSImmunisationsAPIConcern
   extend ActiveSupport::Concern
 
   included do
-    scope :syncable_to_nhs_immunisations_api,
+    scope :with_correct_source_for_nhs_immunisations_api,
           -> do
             includes(:patient).then do
               it.sourced_from_service.or(it.sourced_from_bulk_upload)
@@ -17,7 +17,7 @@ module VaccinationRecordSyncToNHSImmunisationsAPIConcern
               Programme.all.select { Flipper.enabled?(:imms_api_sync_job, it) }
 
             ids =
-              syncable_to_nhs_immunisations_api.for_programmes(
+              with_correct_source_for_nhs_immunisations_api.for_programmes(
                 programmes
               ).pluck(:id)
 
@@ -33,7 +33,7 @@ module VaccinationRecordSyncToNHSImmunisationsAPIConcern
     after_commit :queue_sync_to_nhs_immunisations_api
   end
 
-  def syncable_to_nhs_immunisations_api?
+  def correct_source_for_nhs_immunisations_api?
     (sourced_from_service? || sourced_from_bulk_upload?)
   end
 
@@ -67,14 +67,14 @@ def changes_need_to_be_synced_to_nhs_immunisations_api?
 
   def touch_nhs_immunisations_api_sync_pending_at
     return unless Flipper.enabled?(:imms_api_sync_job, programme)
-    return unless syncable_to_nhs_immunisations_api?
+    return unless correct_source_for_nhs_immunisations_api?
 
     self.nhs_immunisations_api_sync_pending_at = Time.current
   end
 
   def queue_sync_to_nhs_immunisations_api
     return unless Flipper.enabled?(:imms_api_sync_job, programme)
-    return unless syncable_to_nhs_immunisations_api?
+    return unless correct_source_for_nhs_immunisations_api?
     return if nhs_immunisations_api_sync_pending_at.nil?
 
     if nhs_immunisations_api_synced_at &&

spec/lib/nhs/immunisations_api_spec.rb

@@ -683,7 +683,7 @@
     context "when the vaccination record doesn't have the correct source" do
       before do
         allow(vaccination_record).to receive(
-          :syncable_to_nhs_immunisations_api?
+          :correct_source_for_nhs_immunisations_api?
         ).and_return(false)
       end
 

spec/models/concerns/vaccination_record_sync_to_nhs_immunisations_api_concern_spec.rb

@@ -29,7 +29,7 @@
     context "when the vaccination record isn't syncable" do
       before do
         allow(vaccination_record).to receive(
-          :syncable_to_nhs_immunisations_api?
+          :correct_source_for_nhs_immunisations_api?
         ).and_return(false)
       end
 
@@ -71,8 +71,8 @@
     end
   end
 
-  describe "syncable_to_nhs_immunisations_api scope" do
-    subject { VaccinationRecord.syncable_to_nhs_immunisations_api }
+  describe "with_correct_source_for_nhs_immunisations_api scope" do
+    subject { VaccinationRecord.with_correct_source_for_nhs_immunisations_api }
 
     let!(:vaccination_record) do
       create(:vaccination_record, programme:, session:)
@@ -109,8 +109,8 @@
     end
   end
 
-  describe "#syncable_to_nhs_immunisations_api?" do
-    subject { vaccination_record.syncable_to_nhs_immunisations_api? }
+  describe "#correct_source_to_nhs_immunisations_api?" do
+    subject { vaccination_record.correct_source_for_nhs_immunisations_api? }
 
     context "when the vaccination record is eligible to sync" do
       it { should be true }