Create all appointment models in advance for clinic bookings

This commit is the start of work to support iteration through multiple children (or appointments) in the parents' clinic booking journey. It will allow us to map out the full wizard journey but still needs to be supported by dynamic generation of the appointment journey pages for each of the appointments we create (as well as dynamic generation of the health question pages for each of those appointments).

Author: malross

app/controllers/book-into-a-clinic.js

@@ -2,27 +2,26 @@ import { fakerEN_GB as faker } from '@faker-js/faker'
 import wizard from '@x-govuk/govuk-prototype-wizard'
 import _ from 'lodash'
 
-import allProgrammesData from '../datasets/programmes.js'
 import { ParentalRelationship, SessionPresets } from '../enums.js'
-import { ClinicAppointment, ClinicBooking, Programme } from '../models.js'
+import { ClinicAppointment, ClinicBooking } from '../models.js'
 import { kebabToCamelCase } from '../utils/string.js'
 
 export const bookIntoClinicController = {
-  // Load the preset into locals
+  /**
+   * Record the session preset
+   * @param {*} request
+   * @param {*} response
+   * @param {*} next
+   * @param {*} session_preset_slug
+   */
   read(request, response, next, session_preset_slug) {
     // Record both the session preset (aka "primary programme" to the parent) and the programme types that comprises
     const sessionPreset =
       SessionPresets.find((preset) => preset.slug === session_preset_slug) ??
       SessionPresets[0]
     response.locals.sessionPreset = sessionPreset
 
-    // Allow us to list the programmes for which the parent's been invited to book an appointment
-    const programmes = sessionPreset.programmeTypes.map((pt) =>
-      Programme.findOne(allProgrammesData[pt].id, request.session.data)
-    )
-    response.locals.programmes = programmes
-
-    // Allow us to offer a phone booking if not wanting online
+    // Allow us to offer a phone booking if not wanting online (start.njk)
     response.locals.bookingPhoneNumber =
       request.session.data.teams[0]?.tel ??
       faker.helpers.replaceSymbols('01### ######')
@@ -52,11 +51,6 @@ export const bookIntoClinicController = {
     const { data } = request.session
     const { sessionPreset } = response.locals
 
-    // TODO:
-    //  [X] Add a SessionPreset property to the ClinicBooking model, so that we know what type of session the children have been invited to.
-    //  [ ] Update the generators to make sure things are created right
-    //  [ ] Create enough different clinic sessions of the right types to cover the different presets?
-
     // Create a new clinic booking in the wizard context
     const booking = ClinicBooking.createInContext(
       {
@@ -128,6 +122,9 @@ export const bookIntoClinicController = {
           data
         )
         response.locals.appointment = appointment
+        response.locals.childNumber =
+          booking.appointments_ids.indexOf(appointment.uuid) + 1
+        response.locals.childCount = booking.appointments_ids.length
         response.locals.firstName =
           appointment.unmatchedFirstName || 'your child'
         response.locals.fullName = appointment.fullName || undefined
@@ -172,7 +169,7 @@ export const bookIntoClinicController = {
             }
         },
       [`/${session_preset_slug}/${booking_uuid}/new/${appointment_uuid}/parental-relationship`]:
-        {}, // allow the *booking* to continue, but stress that someone with responsibility must *attend*
+        {}, // TODO: allow the *booking* to continue, but stress that someone with responsibility must *attend*
       [`/${session_preset_slug}/${booking_uuid}/new/${appointment_uuid}/vaccination-choice`]:
         {},
       [`/${session_preset_slug}/${booking_uuid}/new/${appointment_uuid}/extra-time`]:
@@ -278,7 +275,7 @@ export const bookIntoClinicController = {
     let key
     if (view.startsWith('health-question-')) {
       key = kebabToCamelCase(view.replace('health-question-', ''))
-      view = 'health-question' // TODO: reintroduce
+      view = 'health-question'
     }
 
     // Only ask for details if question does not have sub-questions
@@ -299,10 +296,7 @@ export const bookIntoClinicController = {
     const { data } = request.session
     const { paths } = response.locals
 
-    // console.log("data.wizard: " + JSON.stringify(data.wizard, null, 2));
-    // console.log("request.body: " + JSON.stringify(request.body, null, 2));
-
-    // Harvest and store values from forms
+    // Store values from the posted form
     if (request.body.booking) {
       ClinicBooking.update(booking_uuid, request.body.booking, data.wizard)
     }
@@ -319,26 +313,39 @@ export const bookIntoClinicController = {
       _.merge(data.wizard.transaction, request.body.transaction)
     }
 
-    let redirectUrl = paths.next
-
-    // If we've just set the child count, create the appointment to start the sub-journey and
-    // put its uuid into the routes from this point on
-    // TODO: but what about iterating to subsequent children? Can't help feeling the whole ask-up-front pattern is flawed.
+    // If we've just set the child count, create the appointments to start the sub-journey and
+    // put the first uuid into the routes from this point on
     if (request.originalUrl.endsWith('/new/child-count')) {
-      const booking = new ClinicBooking(
-        ClinicBooking.findOne(booking_uuid, data.wizard),
-        data
-      )
-      const appointment = ClinicAppointment.createInContext(
-        { primary_programme_ids: booking.primaryProgrammeIDs },
-        data.wizard
-      )
+      const booking = ClinicBooking.findOne(booking_uuid, data.wizard)
+
+      let desiredCount = Number(data.wizard.transaction.childCount)
+      desiredCount = isNaN(desiredCount) || desiredCount < 1 ? 1 : desiredCount
+      const existingCount = booking.appointments_ids.length
+
+      const childrenToAdd = Math.max(0, desiredCount - existingCount)
+      const childrenToRemove = Math.max(0, existingCount - desiredCount)
+      for (let index = 0; index < childrenToAdd; index++) {
+        const appointment = ClinicAppointment.createInContext(
+          { primary_programme_ids: booking.primaryProgrammeIDs },
+          data.wizard
+        )
 
-      const bookingUri = booking.bookingUri
-      redirectUrl = `${request.baseUrl}/${bookingUri}/new/${appointment.appointmentUri}/child`
-    }
+        booking.addAppointment(appointment)
+      }
+      for (let index = 0; index < childrenToRemove; index++) {
+        const appointment_uuid = booking.removeLastAppointment()
+        ClinicAppointment.delete(appointment_uuid, data.wizard)
+      }
 
-    response.redirect(redirectUrl)
+      // Start the appointment journey for the first child
+      const firstAppointment = booking.appointments[0]
+      response.redirect(
+        `${request.baseUrl}/${booking.bookingUri}/new/${firstAppointment.appointmentUri}/child`
+      )
+    } else {
+      // Continue to the next page in the journey
+      response.redirect(paths.next)
+    }
   },
 
   /**

app/locales/en.js

@@ -287,6 +287,7 @@ export const en = {
     },
     child: {
       title: 'What is your child’s name?',
+      caption: 'Appointment for your %s child',
       summary: 'About your child',
       description:
         'Give the name on your child’s birth certificate. If it’s changed, give the name held by your child’s GP.',

app/models/clinic-booking.js

@@ -86,14 +86,23 @@ export class ClinicBooking {
   }
 
   /**
-   * Add a child's appointment to this booking, setting up parent details and relationship in the process
+   * Add a child's appointment to this booking
    *
    * @param {ClinicAppointment} appointment - An appointment to make part of this booking
    */
   addAppointment(appointment) {
     this.appointments_ids.push(appointment.uuid)
   }
 
+  /**
+   * Remove the last appointment added to this booking
+   *
+   * @returns {string} the uuid of the removed appointment
+   */
+  removeLastAppointment() {
+    return this.appointments_ids.pop()
+  }
+
   /**
    * Get appointments
    *

app/views/book-into-a-clinic/form/child.njk

@@ -4,7 +4,8 @@
 
 {% block form %}
   {{ appHeading({
-    title: title
+    title: title,
+    caption: __("clinicBooking.child.caption", childNumber | ordinal) if childCount > 1
   }) }}
 
   {{ __("clinicBooking.child.description") | nhsukMarkdown }}
@@ -20,27 +21,4 @@
     hint: { text: __("clinicBooking.child.lastName.hint") },
     decorate: "appointment.unmatchedLastName"
   }) }}
-
-  {#
-  {{ radios({
-    fieldset: {
-      legend: { text: __("clinicBooking.child.hasPreferredName.label") }
-    },
-    items: [{
-      text: __("clinicBooking.child.hasPreferredName.yes"),
-      conditional: {
-        html: input({
-          label: { text: __("clinicBooking.child.preferredFirstName.label") + " (optional)" },
-          decorate: "clinicBooking.appointments[child_index].preferredFirstName"
-        }) + input({
-          label: { text: __("clinicBooking.child.preferredLastName.label") + " (optional)" },
-          decorate: "clinicBooking.appointments[child_index].preferredLastName"
-        })
-      }
-    }, {
-      text: __("clinicBooking.child.hasPreferredName.no")
-    }],
-    decorate: "child.preferred-name-choice"
-  }) }}
-    #}
 {% endblock %}