fixup! Ensure all non eligibility questions can only be answered when eligible

Author: Themitchell

features/age_when_started_smoking.feature

@@ -2,12 +2,13 @@
 Feature: Age when started smoking
   Scenario: The page is accessible
     Given I am logged in
-    And I am 60 years old
+    And I have answered questions showing I am eligible
     When I go to "/age-when-started-smoking"
     Then there are no accessibility violations
 
   Scenario: Form errors
     Given I am logged in
+    And I have answered questions showing I am eligible
     And I am 60 years old
     When I go to "/age-when-started-smoking"
     And I click "Continue"
@@ -21,15 +22,15 @@ Feature: Age when started smoking
 
   Scenario: Navigating backwards and forwards
     Given I am logged in
-    And I am 60 years old
+    And I have answered questions showing I am eligible
     When I go to "/age-when-started-smoking"
     Then I see a back link to "/relatives-age-when-diagnosed"
     When I fill in "How old were you when you started smoking?" as "18" and submit
     Then I am on "/check-your-answers"
 
   Scenario: Checking responses and changing them
     Given I am logged in
-    And I am 60 years old
+    And I have answered questions showing I am eligible
     When I go to "/age-when-started-smoking"
     And I fill in "How old were you when you started smoking?" as "18" and submit
     When I go to "/check-your-answers"

lung_cancer_screening/questions/tests/unit/views/test_age_when_started_smoking.py

@@ -1,23 +1,15 @@
 from django.test import TestCase, tag
 from django.urls import reverse
-from django.utils import timezone
-from dateutil.relativedelta import relativedelta
-
-
-
-from lung_cancer_screening.questions.tests.factories.date_of_birth_response_factory import DateOfBirthResponseFactory
-
-from ...factories.response_set_factory import ResponseSetFactory
-
 
 from .helpers.authentication import login_user
+from ...factories.response_set_factory import ResponseSetFactory
 
 @tag("AgeWhenStartedSmoking")
 class TestGetAgeWhenStartedSmoking(TestCase):
     def setUp(self):
         self.user = login_user(self.client)
 
-    def test_get_redirects_if_the_user_is_not_logged_in(self):
+    def test_redirects_if_the_user_is_not_logged_in(self):
         self.client.logout()
 
         response = self.client.get(
@@ -30,9 +22,7 @@ def test_get_redirects_if_the_user_is_not_logged_in(self):
             fetch_redirect_response=False
         )
 
-    def test_get_redirects_when_submitted_response_set_exists_within_last_year(
-        self
-    ):
+    def test_redirects_when_an_submitted_response_set_exists_within_the_last_year(self):
         ResponseSetFactory.create(
             user=self.user,
             recently_submitted=True
@@ -44,7 +34,18 @@ def test_get_redirects_when_submitted_response_set_exists_within_last_year(
 
         self.assertRedirects(response, reverse("questions:confirmation"))
 
-    def test_get_responds_successfully(self):
+    def test_redirects_when_the_user_is_not_eligible(self):
+        ResponseSetFactory.create(user=self.user, eligible=False)
+
+        response = self.client.get(
+            reverse("questions:age_when_started_smoking")
+        )
+
+        self.assertRedirects(response, reverse("questions:have_you_ever_smoked"))
+
+    def test_responds_successfully(self):
+        ResponseSetFactory.create(user=self.user, eligible=True)
+
         response = self.client.get(
             reverse("questions:age_when_started_smoking")
         )
@@ -57,7 +58,7 @@ def setUp(self):
 
         self.valid_params = {"value": 18}
 
-    def test_post_redirects_if_the_user_is_not_logged_in(self):
+    def test_redirects_if_the_user_is_not_logged_in(self):
         self.client.logout()
 
         response = self.client.post(
@@ -71,73 +72,41 @@ def test_post_redirects_if_the_user_is_not_logged_in(self):
             fetch_redirect_response=False
         )
 
-    def test_post_creates_unsubmitted_response_set_when_no_response_set_exists(
-        self
-    ):
-        self.client.post(
-            reverse("questions:age_when_started_smoking")
-        )
-
-        response_set = self.user.responseset_set.first()
-        self.assertEqual(self.user.responseset_set.count(), 1)
-        self.assertEqual(response_set.submitted_at, None)
-        self.assertEqual(response_set.user, self.user)
-
-    def test_post_updates_unsubmitted_response_set_when_one_exists(self):
-        response_set = self.user.responseset_set.create()
-        DateOfBirthResponseFactory(
-            response_set=response_set
-        )
-
-        self.client.post(
-            reverse("questions:age_when_started_smoking")
-        )
-
-        response_set.refresh_from_db()
-        self.assertEqual(self.user.responseset_set.count(), 1)
-        self.assertEqual(response_set.submitted_at, None)
-        self.assertEqual(response_set.user, self.user)
-
-    def test_post_creates_new_unsubmitted_response_set_when_submitted_exists_over_year_ago(
-        self
-    ):
+    def test_redirects_when_an_submitted_response_set_exists_within_the_last_year(self):
         ResponseSetFactory.create(
             user=self.user,
-            not_recently_submitted=True
+            recently_submitted=True
         )
 
-        self.client.post(
-            reverse("questions:age_when_started_smoking")
+        response = self.client.post(
+            reverse("questions:age_when_started_smoking"),
+            self.valid_params
         )
 
-        self.assertEqual(self.user.responseset_set.count(), 2)
-        self.assertEqual(self.user.responseset_set.unsubmitted().count(), 1)
+        self.assertRedirects(response, reverse("questions:confirmation"))
 
-        response_set = self.user.responseset_set.last()
-        self.assertEqual(response_set.submitted_at, None)
-        self.assertEqual(response_set.user, self.user)
-
-    def test_post_redirects_when_submitted_response_set_exists_within_last_year(
-        self
-    ):
-        ResponseSetFactory.create(
-            user=self.user,
-            recently_submitted=True
-        )
+    def test_redirects_when_the_user_is_not_eligible(self):
+        ResponseSetFactory.create(user=self.user)
 
         response = self.client.post(
-            reverse("questions:age_when_started_smoking")
+            reverse("questions:age_when_started_smoking"),
+            self.valid_params
         )
 
-        self.assertRedirects(response, reverse("questions:confirmation"))
+        self.assertRedirects(response, reverse("questions:have_you_ever_smoked"))
+
+    def test_creates_an_age_when_started_smoking_response(self):
+        response_set = ResponseSetFactory.create(user=self.user, eligible=True)
+
+        self.client.post(reverse("questions:age_when_started_smoking"), self.valid_params)
 
-    def test_post_redirects_to_responses(self):
-        self.response_set = ResponseSetFactory()
-        DateOfBirthResponseFactory(
-            response_set=self.response_set,
-            value=timezone.now() - relativedelta(years=int(60))
+        response_set.refresh_from_db()
+        self.assertEqual(
+            response_set.age_when_started_smoking_response.value, self.valid_params["value"]
         )
-        self.user.responseset_set.set({self.response_set})
+
+    def test_redirects_to_responses(self):
+        ResponseSetFactory.create(user=self.user, eligible=True)
 
         response = self.client.post(
             reverse("questions:age_when_started_smoking"),
@@ -146,13 +115,8 @@ def test_post_redirects_to_responses(self):
 
         self.assertRedirects(response, reverse("questions:responses"))
 
-    def test_post_redirects_to_responses_if_change_query_param_is_true(self):
-        self.response_set = ResponseSetFactory()
-        DateOfBirthResponseFactory(
-            response_set=self.response_set,
-            value=timezone.now() - relativedelta(years=int(60))
-        )
-        self.user.responseset_set.set({self.response_set})
+    def test_redirects_to_responses_if_change_query_param_is_true(self):
+        ResponseSetFactory.create(user=self.user, eligible=True)
 
         response = self.client.post(
             reverse("questions:age_when_started_smoking"),
@@ -163,3 +127,13 @@ def test_post_redirects_to_responses_if_change_query_param_is_true(self):
         )
 
         self.assertRedirects(response, reverse("questions:responses"))
+
+    def test_responds_with_422_if_the_response_fails_to_create(self):
+        ResponseSetFactory.create(user=self.user, eligible=True)
+
+        response = self.client.post(
+            reverse("questions:age_when_started_smoking"),
+            {"value": "not a valid age"}
+        )
+
+        self.assertEqual(response.status_code, 422)

lung_cancer_screening/questions/views/age_when_started_smoking.py

@@ -1,10 +1,13 @@
 from django.urls import reverse_lazy
+from django.contrib.auth.mixins import LoginRequiredMixin
 
+from .mixins.ensure_response_set import EnsureResponseSet
+from .mixins.ensure_eligible import EnsureEligibleMixin
 from .question_base_view import QuestionBaseView
 from ..forms.age_when_started_smoking_form import AgeWhenStartedSmokingForm
 from ..models.age_when_started_smoking_response import AgeWhenStartedSmokingResponse
 
-class AgeWhenStartedSmokingView(QuestionBaseView):
+class AgeWhenStartedSmokingView(LoginRequiredMixin, EnsureResponseSet, EnsureEligibleMixin, QuestionBaseView):
     template_name = "question_form.jinja"
     form_class = AgeWhenStartedSmokingForm
     model = AgeWhenStartedSmokingResponse