Implement weight collection feature with comprehensive tests

Author: miriam-z

lung_cancer_screening/core/tests/acceptance/helpers/user_interaction_helpers.py

@@ -38,7 +38,7 @@ def fill_in_and_submit_height_imperial(page, feet, inches):
 
     page.click("text=Continue")
 
-def fill_in_and_submit_weight(page, kilograms):
+def fill_in_and_submit_weight_metric(page, kilograms):
     expect(page.locator("h1")).to_have_text("Enter your weight")
 
     page.get_by_label("Kilograms").fill(str(kilograms))

lung_cancer_screening/core/tests/acceptance/test_questionnaire.py

@@ -10,7 +10,7 @@
     fill_in_and_submit_participant_id,
     fill_in_and_submit_smoking_eligibility,
     fill_in_and_submit_date_of_birth,
-    fill_in_and_submit_weight
+    fill_in_and_submit_weight_metric
 )
 
 from .helpers.assertion_helpers import expect_back_link_to_have_url
@@ -37,6 +37,9 @@ def test_full_questionnaire_user_journey(self):
         height = "170"
         feet = 5
         inches = 7
+        weight_metric = 70
+        weight_stone = 5
+        weight_pound = 10
 
         page = self.browser.new_page()
         page.goto(f"{self.live_server_url}/start")
@@ -69,15 +72,19 @@ def test_full_questionnaire_user_journey(self):
 
         expect(page).to_have_url(f"{self.live_server_url}/weight")
 
-        fill_in_and_submit_weight(page, "70")
+        fill_in_and_submit_weight_metric(page, weight_metric)
 
         expect(page).to_have_url(f"{self.live_server_url}/responses")
-
+        page.click("text=Back")
+        page.click("text=Switch to imperial")
+        fill_in_and_submit_weight_imperial(page, weight_stone, weight_pound)
         responses = page.locator(".responses")
         expect(responses).to_contain_text("Have you ever smoked? Yes, I used to smoke regularly")
         expect(responses).to_contain_text(
             age.strftime("What is your date of birth? %Y-%m-%d"))
         expect(responses).to_contain_text(f"What is your height? {feet} feet {inches} inches")
+        # expect(responses).to_contain_text(f"What is your weight? {weight_metric}kg")
+        expect(responses).to_contain_text(f"What is your weight? {weight_stone} stone {weight_pound} pound")
 
         page.click("text=Submit")
 

lung_cancer_screening/questions/tests/unit/forms/test_metric_weight_form.py

@@ -30,8 +30,19 @@ def test_is_not_valid_with_invalid_input(self):
         )
         self.assertFalse(form.is_valid())
 
+    # UAT: Error message when nothing is entered
+    def test_error_message_when_weight_is_empty(self):
+        form = MetricWeightForm(
+            participant=self.participant,
+            instance=self.response_set,
+            data={
+                "weight_metric": ""
+            }
+        )
+        self.assertFalse(form.is_valid())
+        self.assertEqual(form.errors["weight_metric"], ["Enter your weight."])
+
     def test_is_not_valid_without_any_weight_value_set(self):
-        weight = "a"
         form = MetricWeightForm(
             participant=self.participant,
             instance=self.response_set,
@@ -41,3 +52,51 @@ def test_is_not_valid_without_any_weight_value_set(self):
         )
         self.assertFalse(form.is_valid())
         self.assertEqual(form.errors, {"weight_metric": ["Enter your weight."]})
+
+    # UAT: Error message for weight below minimum (25.4kg)
+    def test_error_message_when_weight_below_minimum(self):
+        form = MetricWeightForm(
+            participant=self.participant,
+            instance=self.response_set,
+            data={
+                "weight_metric": "20.0"
+            }
+        )
+        self.assertFalse(form.is_valid())
+        self.assertIn("Weight must be between 25.4kg and 317.5kg",
+                     form.errors["weight_metric"][0])
+
+    # UAT: Error message for weight above maximum (317.5kg)
+    def test_error_message_when_weight_above_maximum(self):
+        form = MetricWeightForm(
+            participant=self.participant,
+            instance=self.response_set,
+            data={
+                "weight_metric": "320.0"
+            }
+        )
+        self.assertFalse(form.is_valid())
+        self.assertIn("Weight must be between 25.4kg and 317.5kg",
+                     form.errors["weight_metric"][0])
+
+    # UAT: Edge case - minimum valid weight
+    def test_accepts_minimum_valid_weight(self):
+        form = MetricWeightForm(
+            participant=self.participant,
+            instance=self.response_set,
+            data={
+                "weight_metric": "25.4"
+            }
+        )
+        self.assertTrue(form.is_valid())
+
+    # UAT: Edge case - maximum valid weight
+    def test_accepts_maximum_valid_weight(self):
+        form = MetricWeightForm(
+            participant=self.participant,
+            instance=self.response_set,
+            data={
+                "weight_metric": "317.5"
+            }
+        )
+        self.assertTrue(form.is_valid())

lung_cancer_screening/questions/tests/unit/models/test_response_set.py

@@ -52,7 +52,7 @@ def test_has_an_imperial_height_as_a_int(self):
         )
 
     def test_has_an_metric_weight_as_a_int(self):
-        self.response_set.weight_metric = 68
+        self.response_set.weight_metric = 680
         self.response_set.save()
 
         self.assertIsInstance(
@@ -189,3 +189,14 @@ def test_is_invalid_if_weight_metric_is_below_lower_bound(self):
             "Weight must be between 25.4kg and 317.5kg",
             context.exception.messages
         )
+
+    def test_is_invalid_if_weight_metric_is_above_upper_bound(self):
+        self.response_set.weight_metric = ResponseSet.MAX_WEIGHT_METRIC + 1
+
+        with self.assertRaises(ValidationError) as context:
+            self.response_set.full_clean()
+
+        self.assertIn(
+            "Weight must be between 25.4kg and 317.5kg",
+            context.exception.messages
+        )

lung_cancer_screening/questions/tests/unit/views/test_weight.py

@@ -82,7 +82,7 @@ def test_post_valid_weight_added_to_response_set(self):
         )
 
         response_set = self.participant.responseset_set.first()
-        self.assertEqual(response_set.weight_metric, self.valid_weight)
+        self.assertEqual(response_set.weight_metric, self.valid_weight * 10)
 
 
     def test_post_responds_with_422_if_the_resource_is_invalid(self):